From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] cifs-utils: Update to version 6.14
Date: Thu, 10 Mar 2022 14:43:39 +0100
Message-ID: <e2d28a9b-84ed-da45-6291-fdf5f00d1c2d@ipfire.org>
In-Reply-To: <4f5f32b2-114c-c427-095e-38be9bbe9948@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8379486113063805758=="
List-Id: <development.lists.ipfire.org>

--===============8379486113063805758==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi All,
I just got a patchwork notification that this patch had been rejected.

On 28/02/2022 22:20, Adolf Belka wrote:
> Hi Peter,
>
> On 28/02/2022 21:39, Peter M=C3=BCller wrote:
>> Hello Adolf,
>>
>> thank you for submitting this.
>>
>> While it looks generally good to me, I did not get why the "SUMMARY"=20
>> line
>> got deleted in it. If this is by mistake, there is no need to hand in=20
>> a second
>> version of this patch - I will just correct that while applying it,=20
>> but want
>> to make sure I got your intention right.
I take it that the correction was not able to be made and that I should=20
re-issue the patch built against the correct, latest, version in next.=20
Should this new patch be a v2 or just create a new one as the old one is=20
rejected?

I will do the patch rebuild after the weekend.

Regards,
Adolf.
> I did a git pull origin next and then used the lfs file from that as=20
> my starting point. So I definitely didn't remove that line although I=20
> have no idea how it was not there on what I copied from the lfs=20
> directory. Yes please correct it.
>>
>> Also, this patch re-introduces (deliberately?) a trailing whitespace,=20
>> which
>> I marked below. Nothing major, just thought I'd mention that... :-)
> Same as above. I did not deliberately add a trailing whitespace. I=20
> didn't touch that line at all so no idea how it happened.
>
> Sorry and thanks for catching.
> Adolf.
>>
>> Acked-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
>>
>> Thanks, and best regards,
>> Peter M=C3=BCller
>>
>>> - Update from 6.13 to 6.14
>>> - Update of rootfile not required
>>> - Changelog
>>> =C2=A0=C2=A0=C2=A0 version 6.14
>>> =C2=A0=C2=A0=C2=A0=C2=A0 setcifsacl: fix formatting
>>> =C2=A0=C2=A0=C2=A0=C2=A0 smbinfo: add support for new key dump ioctl
>>> =C2=A0=C2=A0=C2=A0=C2=A0 mount.cifs: fix crash when mount point does not =
exist
>>> =C2=A0=C2=A0=C2=A0=C2=A0 cifs.upcall: fix regression in kerberos mount
>>> =C2=A0=C2=A0=C2=A0=C2=A0 smbinfo: Add command for displaying alternate da=
ta streams
>>> =C2=A0=C2=A0=C2=A0=C2=A0 Reorder ACEs in preferred order during setcifsacl
>>>
>>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>>> ---
>>> =C2=A0 lfs/cifs-utils | 12 ++++--------
>>> =C2=A0 1 file changed, 4 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/lfs/cifs-utils b/lfs/cifs-utils
>>> index 524c3bcee..08e9b2c28 100644
>>> --- a/lfs/cifs-utils
>>> +++ b/lfs/cifs-utils
>>> @@ -24,9 +24,7 @@
>>> =C2=A0 =C2=A0 include Config
>>> =C2=A0 -SUMMARY=C2=A0=C2=A0=C2=A0 =3D Utilities for doing and managing mo=
unts of the Linux=20
>>> CIFS filesystem
>>> -
>>> -VER=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D 6.13
>>> +VER=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D 6.14
>>> =C2=A0 =C2=A0 THISAPP=C2=A0=C2=A0=C2=A0 =3D cifs-utils-$(VER)
>>> =C2=A0 DL_FILE=C2=A0=C2=A0=C2=A0 =3D $(THISAPP).tar.bz2
>>> @@ -34,12 +32,10 @@ DL_FROM=C2=A0=C2=A0=C2=A0 =3D $(URL_IPFIRE)
>>> =C2=A0 DIR_APP=C2=A0=C2=A0=C2=A0 =3D $(DIR_SRC)/$(THISAPP)
>>> =C2=A0 TARGET=C2=A0=C2=A0=C2=A0=C2=A0 =3D $(DIR_INFO)/$(THISAPP)
>>> =C2=A0 PROG=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D cifs-utils
>>> -PAK_VER=C2=A0=C2=A0=C2=A0 =3D 3
>>> +PAK_VER=C2=A0=C2=A0=C2=A0 =3D 4
>>> =C2=A0 =C2=A0 DEPS=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D
>>> =C2=A0 -SERVICES=C2=A0=C2=A0 =3D
>>> -
>>> #########################################################################=
######
>>> =C2=A0 # Top-level Rules
>>> #########################################################################=
######
>>> @@ -48,7 +44,7 @@ objects =3D $(DL_FILE)
>>> =C2=A0 =C2=A0 $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE)
>>> =C2=A0 -$(DL_FILE)_MD5 =3D 4348921483c530826950e9503b08b033
>>> +$(DL_FILE)_MD5 =3D e918d1246adb841c61e562538c2cc78e
>>> =C2=A0 =C2=A0 install : $(TARGET)
>>> =C2=A0 @@ -58,7 +54,7 @@ download :$(patsubst %,$(DIR_DL)/%,$(objects))
>>> =C2=A0 =C2=A0 md5 : $(subst %,%_MD5,$(objects))
>>> =C2=A0 -dist:
>>> +dist:
>>
>> Trailing whitespace introduced here again. :-)
>>
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 @$(PAK)
>>> #########################################################################=
######

--=20
Sent from my laptop


--===============8379486113063805758==--