From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonatan Schlag To: development@lists.ipfire.org Subject: Re: Start local and uplink network independent Date: Fri, 18 Aug 2023 12:30:03 +0200 Message-ID: In-Reply-To: <5912CCFF-CAEC-4156-AC8F-11E50ED95616@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2256708341583594986==" List-Id: --===============2256708341583594986== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi list, Am Mittwoch, dem 24.05.2023 um 09:59 +0100 schrieb Michael Tremer: > Hello Jonatan, >=20 > Thanks for this *huge* patchset. >=20 > What I do not quite understand from your email is the motivation for > this. Starting the SSH daemon a little bit sooner is not justifying > such massive change. Starting the SSH-Daemon earlier was not the only reason. The main reason was=20 a) to debug problems with the red interface via ssh and via console b) Wait infinitely for a dhcp lease. We currently only wait 30 seconds. If we do not get a lease, red stays down forever.=20 >=20 > I consider this a highly risky patchset as we are touching code that > is already incredibly fragile and the smallest changes might > introduce more problems. >=20 I know that this is a risky patch set. But not touching these code does not improve it. It gets worse each day. Never touch a running system turns against us here. So both change and no change have a risk here. My further plan for this patch set is to split it up even further. My builder is currently running with all the patches you already agreed to. I will send this patch set in the next days. When this is merged, I will go on to review the other patches. Greetings Jonatan > But I have to say that I like how you split this into small patches > that can be reviewed easier. >=20 > > On 23 May 2023, at 18:23, Jonatan Schlag > > wrote: > >=20 > > Hi, > >=20 > > this is the first try for a patch series which makes the startup of > > local and uplink networks independent. This resolves in the end > > #11502. It should further allow us to keep waiting for a DHCP > > lease, because at least our local networks are all up when we get > > to the red network. This might have some small quirks, even when my > > testing so far shows no problems. I still think it is now better to > > share result, then to wait any longer. > > As this touches quite important parts of our network stack, I might > > be a could idea to merge this in two stages. After the patch, > > titled "network startup: Clean up duplicated Code ", might be a > > good breaking point.=C2=A0 But in the end, this is up to you. Please > > keep in mind, I only tested the full patch set: > >=20 > > =C2=A0Remove ipsec interface creation from network startup > > =C2=A0Remove Start/Stop links for client175 > > =C2=A0Use bash as shebang in network initscripts > > =C2=A0network initscripts: check if the zone in the current config > > exists > > =C2=A0network initscripts: Remove code for old zone scheme > > =C2=A0network scripts: remove check for AUTOCONNECT > > =C2=A0network startup: Reload routing informations for every interface > > =C2=A0network startup: Always cleanup before red gets started > > =C2=A0network startup: check for correct action at start > > =C2=A0network startup: Refactor how cmd args are processed > > =C2=A0network startup: Clean up duplicated Code > > =C2=A0network script: add extra scripts for action that depend on a > > network > > =C2=A0network startup: Add scripts for local and uplink > > =C2=A0network startup: Start local and uplink network independent > > =C2=A0network startup: Only work with configured zones > >=20 > > config/rootfiles/common/aarch64/initscripts=C2=A0=C2=A0 |=C2=A0 31 +++-- > > config/rootfiles/common/riscv64/initscripts=C2=A0=C2=A0 |=C2=A0 31 +++-- > > config/rootfiles/common/x86_64/initscripts=C2=A0=C2=A0=C2=A0 |=C2=A0 31 += ++-- > > lfs/initscripts=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 36 +++--- > > src/initscripts/networking/any=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 31 ++++- > > src/initscripts/networking/functions.network=C2=A0 |=C2=A0 14 +- > > src/initscripts/networking/red=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 5 +- > > .../networking/red.up/99-pakfire-update=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 |=C2=A0=C2=A0 2 +- > > src/initscripts/system/depends-on-network=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0= 40 ++++++ > > src/initscripts/system/network=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 121 ++++++++------- > > --- > > 10 files changed, 218 insertions(+), 124 deletions(-) > > create mode 100644 src/initscripts/system/depends-on-network > >=20 > >=20 > > Looking forward to your feedback > >=20 > > Greetings > > Jonatan > >=20 >=20 --===============2256708341583594986==--