public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: Duplicate ipsets listed with Locationblock changes.
Date: Wed, 08 Jun 2022 21:32:20 +0200	[thread overview]
Message-ID: <e63ed50d071e8a0089b0f482e0ce5558dbf92eaa.camel@ipfire.org> (raw)
In-Reply-To: <t7prqe$rc2$1@tuscan3.grantura.co.uk>

[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]

Hello Rob,

a big thanks for testing and reporting this issue here.

The main problem has been fixed a while a ago and also merged into next
and the current master branch. So this should be a part of the
upcomming core update.

After a deeper look I've found that the "rules.pl" file is currently
not shiiped by C168 so the fix would not deplyed.

@Peter: Please add this file to the C168 filelist.

A big thanks in advance,

-Stefan
> Hi All,
> 
> The tests below were made on my 'Testing' APU4 using CU 168 but as
> Adolf has 
> found was identified as CU 167 in the GUI. However I am listing
> duplicate 
> ipsets on my production 'Stable' APU4 with CU 167 installed.
> 
> Rob
> 
> On Tuesday 07 June 2022 15:51 Rob Brewer wrote:
> 
> > If I list the installed ipsets with 'ipset -n list' additional
> > ipsets with
> > the suffix 'v4' are sometimes listed. From what I can see this
> > additional
> > 'v4' list is the same size as the set without the 'v4' extension.
> > 
> > For instance: with just code AR selected with location-block.cgi:
> >  
> > [root(a)ipfire-dev2 ~]# ipset -n list
> > ARv4
> > AR
> > (code AR id duplicated)
> > 
> > if I add code AT to AR and list the sets:
> > [root(a)ipfire-dev2 ~]# ipset -n list
> > AT
> > AR
> > (as expected)
> > 
> > and now add code AW to the other 2:
> > [root(a)ipfire-dev2 ~]# ipset -n list
> > ARv4
> > AT
> > AR
> > ATv4
> > AW
> > (now codes AR and AT are duplicated)
> > 
> > I see this effect on both my core 167 boxes and wasn't aware of
> > this
> > problem before my upgrade from core 161.
> > 
> > Rob
> 



  reply	other threads:[~2022-06-08 19:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-07 14:51 Rob Brewer
2022-06-08  9:57 ` Rob Brewer
2022-06-08 19:32   ` Stefan Schantl [this message]
2022-06-09  8:21     ` Rob Brewer
2022-06-09 19:54     ` Peter Müller
2022-06-10  8:46       ` Rob Brewer
2022-06-11  7:47         ` Peter Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e63ed50d071e8a0089b0f482e0ce5558dbf92eaa.camel@ipfire.org \
    --to=stefan.schantl@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox