From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: Duplicate ipsets listed with Locationblock changes.
Date: Wed, 08 Jun 2022 21:32:20 +0200
Message-ID: <e63ed50d071e8a0089b0f482e0ce5558dbf92eaa.camel@ipfire.org>
In-Reply-To: <t7prqe$rc2$1@tuscan3.grantura.co.uk>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6470150137196836823=="
List-Id: <development.lists.ipfire.org>

--===============6470150137196836823==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Hello Rob,

a big thanks for testing and reporting this issue here.

The main problem has been fixed a while a ago and also merged into next
and the current master branch. So this should be a part of the
upcomming core update.

After a deeper look I've found that the "rules.pl" file is currently
not shiiped by C168 so the fix would not deplyed.

@Peter: Please add this file to the C168 filelist.

A big thanks in advance,

-Stefan
> Hi All,
> 
> The tests below were made on my 'Testing' APU4 using CU 168 but as
> Adolf has 
> found was identified as CU 167 in the GUI. However I am listing
> duplicate 
> ipsets on my production 'Stable' APU4 with CU 167 installed.
> 
> Rob
> 
> On Tuesday 07 June 2022 15:51 Rob Brewer wrote:
> 
> > If I list the installed ipsets with 'ipset -n list' additional
> > ipsets with
> > the suffix 'v4' are sometimes listed. From what I can see this
> > additional
> > 'v4' list is the same size as the set without the 'v4' extension.
> > 
> > For instance: with just code AR selected with location-block.cgi:
> >  
> > [root(a)ipfire-dev2 ~]# ipset -n list
> > ARv4
> > AR
> > (code AR id duplicated)
> > 
> > if I add code AT to AR and list the sets:
> > [root(a)ipfire-dev2 ~]# ipset -n list
> > AT
> > AR
> > (as expected)
> > 
> > and now add code AW to the other 2:
> > [root(a)ipfire-dev2 ~]# ipset -n list
> > ARv4
> > AT
> > AR
> > ATv4
> > AW
> > (now codes AR and AT are duplicated)
> > 
> > I see this effect on both my core 167 boxes and wasn't aware of
> > this
> > problem before my upgrade from core 161.
> > 
> > Rob
> 



--===============6470150137196836823==--