Testing 'rules.pl'

[Matthias Fischer <matthias.fischer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1734 bytes --]

Hi,

Being curious, I tested
https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=1b70ead36dfaf6541677e4ac5d05867273eaa265
on Core 173 today => "firewall: Silence warnings if blocklist logging is
not set".

Bug-Reference: #12979.

But when I try to restart the firewall, I get:

...
root(a)ipfire: /usr/lib/firewall # /etc/init.d/firewall restart
Setting up firewall
syntax error at /usr/lib/firewall/rules.pl line 764, near ") &&"
Global symbol "$blocklist" requires explicit package name (did you
forget to declare "my $blocklist"?) at /usr/lib/firewall/rules.pl line 770.
Global symbol "$blocklist" requires explicit package name (did you
forget to declare "my $blocklist"?) at /usr/lib/firewall/rules.pl line 773.
Global symbol "$blocklist" requires explicit package name (did you
forget to declare "my $blocklist"?) at /usr/lib/firewall/rules.pl line 773.
Global symbol "$blocklist" requires explicit package name (did you
forget to declare "my $blocklist"?) at /usr/lib/firewall/rules.pl line 774.
Global symbol "$blocklist" requires explicit package name (did you
forget to declare "my $blocklist"?) at /usr/lib/firewall/rules.pl line 774.
syntax error at /usr/lib/firewall/rules.pl line 777, near "} else"
Global symbol "$blocklist" requires explicit package name (did you
forget to declare "my $blocklist"?) at /usr/lib/firewall/rules.pl line 784.
syntax error at /usr/lib/firewall/rules.pl line 785, near "}"
Can't redeclare "my" in "my" at /usr/lib/firewall/rules.pl line 792,
near "my"
/usr/lib/firewall/rules.pl has too many errors.
...

The old version of 'rules.pl' is working without problems.

Am I doing something wrong or is there anything still missing!?

Best,
Matthias