From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthias Fischer <matthias.fischer@ipfire.org>
To: development@lists.ipfire.org
Subject: Testing 'rules.pl'
Date: Sun, 12 Mar 2023 10:45:18 +0100
Message-ID: <e6c5dd9e-fd81-7a7d-091c-6fd29263c62e@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8758331326874961313=="
List-Id: <development.lists.ipfire.org>

--===============8758331326874961313==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

Being curious, I tested
https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dcommitdiff;h=3D1b70ead36dfaf65=
41677e4ac5d05867273eaa265
on Core 173 today =3D> "firewall: Silence warnings if blocklist logging is
not set".

Bug-Reference: #12979.

But when I try to restart the firewall, I get:

...
root(a)ipfire: /usr/lib/firewall # /etc/init.d/firewall restart
Setting up firewall
syntax error at /usr/lib/firewall/rules.pl line 764, near ") &&"
Global symbol "$blocklist" requires explicit package name (did you
forget to declare "my $blocklist"?) at /usr/lib/firewall/rules.pl line 770.
Global symbol "$blocklist" requires explicit package name (did you
forget to declare "my $blocklist"?) at /usr/lib/firewall/rules.pl line 773.
Global symbol "$blocklist" requires explicit package name (did you
forget to declare "my $blocklist"?) at /usr/lib/firewall/rules.pl line 773.
Global symbol "$blocklist" requires explicit package name (did you
forget to declare "my $blocklist"?) at /usr/lib/firewall/rules.pl line 774.
Global symbol "$blocklist" requires explicit package name (did you
forget to declare "my $blocklist"?) at /usr/lib/firewall/rules.pl line 774.
syntax error at /usr/lib/firewall/rules.pl line 777, near "} else"
Global symbol "$blocklist" requires explicit package name (did you
forget to declare "my $blocklist"?) at /usr/lib/firewall/rules.pl line 784.
syntax error at /usr/lib/firewall/rules.pl line 785, near "}"
Can't redeclare "my" in "my" at /usr/lib/firewall/rules.pl line 792,
near "my"
/usr/lib/firewall/rules.pl has too many errors.
...

The old version of 'rules.pl' is working without problems.

Am I doing something wrong or is there anything still missing!?

Best,
Matthias

--===============8758331326874961313==--