From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter =?utf-8?q?M=C3=BCller?= To: development@lists.ipfire.org Subject: Re: [PATCH] ddns: Add provider Feste-IP.Net Signed-off-by: Martin Krieger --- *IPv6 support included based on API description but not tested. *Test system is connected by VDSL with pure IPv4 (No IPv6 or dual stack). *Setup can handle IPv4, IPv6 or dual stack updates Date: Mon, 17 May 2021 21:31:38 +0200 Message-ID: In-Reply-To: <20210517141804.5808-1-makrie@posteo.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7320278124703046164==" List-Id: --===============7320278124703046164== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi, thank you for providing this. I regret to inform you that (a) both this patch and it's precursor violate the syntax of patches applicab= le to git, having parts of the description and various tags mangled into the RFC 532= 2 / MIME "Subject" header. You do not need to use "git send-email" as such (personally, I do not use= it either, because my development environment cannot establish SMTP connections due = to firewall policies). However, IPFire's development heavily relies on Git, so please= figure out how to run the most basic commands such as "git commit" and "git format-p= atch" in order to properly submit your patches. (b) these patches each success each other, however missing appropriate versio= n tags (such as [PATCH v2], [PATCH v3], etc.) in the RFC 5322 "Subject" header o= f their mails. Since you did not mark the obsoleted patches as being superseded in https= ://patchwork.ipfire.org/, either, this makes it hard to keep track of the latest version of your pa= tch. Eventually, we might apply, commend or reject based on the wrong one, because of simp= ly having overlooked there is a new, fixed version of it available. Apart from that, it would be good to see this patch tested with IPv6 and dual= -stack scenarios as well - please see also my remark(s) on this below. If I understood the doc= umentation of that DDNS provider correctly, you do not really need to supply two IP address= es having distinct families. Could you at least try executing this snippet with two different IP= v4 addresses? > --- > README | 1 + > src/ddns/providers.py | 27 +++++++++++++++++++++++++++ > 2 files changed, 28 insertions(+) >=20 > diff --git a/README b/README > index b6decb35c338..fa6ce5e598b8 100644 > --- a/README > +++ b/README > @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS: > easydns.com > enom.com > entrydns.net > + feste-ip.net > freedns.afraid.org > inwx.com|de|at|ch|es > itsdns.de > diff --git a/src/ddns/providers.py b/src/ddns/providers.py > index 56e6620c78ab..009e2c9e337d 100644 > --- a/src/ddns/providers.py > +++ b/src/ddns/providers.py > @@ -1179,6 +1179,33 @@ class DDNSProviderEntryDNS(DDNSProvider): > raise DDNSUpdateError > =20 > =20 > +class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider): > + handle =3D "feste-ip.net" > + name =3D "Feste-IP.Net" > + website =3D "https://www.feste-ip.net/" > + > + # Information about the format of the request is to be found > + # https://forum.feste-ip.net/viewtopic.php?f=3D13&t=3D469 > + > + myips =3D ("myip","myip2") Personal comment: Kinda ugly, but given the documentation of that provider, t= here is no other choice to do this here... > + > + url =3D "https://members.feste-ip.net/nic/update/" > + > + def update(self): > + data =3D { > + "hostname" : self.hostname > + } > + > + for proto in DDNSProvider.protocols: > + idx =3D 0 > + tmpip =3D self.get_address(proto) > + if tmpip: > + data[self.myips[idx]] =3D tmpip > + idx +=3D 1 > + > + self.send_request(data) What is happening here if $tmpip equals a Boolean False? > + > + > class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): > handle =3D "freedns.afraid.org" > name =3D "freedns.afraid.org" >=20 Thanks, and best regards, Peter M=C3=BCller --===============7320278124703046164==--