Re: [PATCH] make.sh: SIGKILL and SIGSTOP cannot be trapped

["Peter Müller" <peter.mueller@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]

Hello Michael,

rather cosmetic. shellcheck complains about this, and I was wondering why
a SIGSTOP'ed build caused my workstation to malfunction until a reboot the
other way.

The current "trap" command just arises false expectations... :-)

Thanks, and best regards,
Peter Müller

> Hello,
> 
> Is this a cosmetic change or does this fix a real world problem?
> 
> -Michael
> 
>> On 16 Feb 2022, at 17:24, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>
>> There is no sense in instructing "trap" to catch signals it cannot trap
>> whatsoever.
>>
>> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
>> ---
>> make.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/make.sh b/make.sh
>> index 4dd068e4b..c06b4ec38 100755
>> --- a/make.sh
>> +++ b/make.sh
>> @@ -437,7 +437,7 @@ prepareenv() {
>> 	fi
>>
>> 	# Trap on emergency exit
>> -	trap "exiterror 'Build process interrupted'" SIGINT SIGTERM SIGKILL SIGSTOP SIGQUIT
>> +	trap "exiterror 'Build process interrupted'" SIGINT SIGTERM SIGQUIT
>>
>> 	# Checking if running as root user
>> 	if [ $(id -u) -ne 0 ]; then
>> -- 
>> 2.34.1
>