From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] make.sh: SIGKILL and SIGSTOP cannot be trapped
Date: Wed, 16 Feb 2022 17:27:44 +0000
Message-ID: <e8b3d750-ce6f-d9e5-958d-d1e0e9410d4a@ipfire.org>
In-Reply-To: <A2679868-92AF-4B9E-A49B-91D8D89ABCB2@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0757771242607292498=="
List-Id: <development.lists.ipfire.org>

--===============0757771242607292498==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Michael,

rather cosmetic. shellcheck complains about this, and I was wondering why
a SIGSTOP'ed build caused my workstation to malfunction until a reboot the
other way.

The current "trap" command just arises false expectations... :-)

Thanks, and best regards,
Peter M=C3=BCller

> Hello,
>=20
> Is this a cosmetic change or does this fix a real world problem?
>=20
> -Michael
>=20
>> On 16 Feb 2022, at 17:24, Peter M=C3=BCller <peter.mueller(a)ipfire.org> w=
rote:
>>
>> There is no sense in instructing "trap" to catch signals it cannot trap
>> whatsoever.
>>
>> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
>> ---
>> make.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/make.sh b/make.sh
>> index 4dd068e4b..c06b4ec38 100755
>> --- a/make.sh
>> +++ b/make.sh
>> @@ -437,7 +437,7 @@ prepareenv() {
>> 	fi
>>
>> 	# Trap on emergency exit
>> -	trap "exiterror 'Build process interrupted'" SIGINT SIGTERM SIGKILL SIGS=
TOP SIGQUIT
>> +	trap "exiterror 'Build process interrupted'" SIGINT SIGTERM SIGQUIT
>>
>> 	# Checking if running as root user
>> 	if [ $(id -u) -ne 0 ]; then
>> --=20
>> 2.34.1
>=20

--===============0757771242607292498==--