From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] installer: Remove support for ReiserFS
Date: Thu, 03 Mar 2022 21:38:35 +0000
Message-ID: <e95bdc7c-d11b-f301-7ce0-6f0b775de001@ipfire.org>
In-Reply-To: <20220303183732.1986097-1-michael.tremer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1169360252591201362=="
List-Id: <development.lists.ipfire.org>

--===============1169360252591201362==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Acked-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>

> https://lore.kernel.org/lkml/YhIwUEpymVzmytdp(a)casper.infradead.org/
>=20
> ReiserFS is an old file system which has not been actively maintained in
> the Linux kernel for a long time. It is potentially going to be removed
> soon which is why we shouldn't encourage people to create new
> installations with ReiserFS any more.
>=20
> This patch removes support for ReiserFS from the installer.
>=20
> We should keep it enabled in the kernel for as long as it is available,
> but we will have to encourage users potentially to re-install on a
> different file system.
>=20
> Since ReiserFS isn't very popular any more, I don't think that there
> will be many users left.
>=20
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
>  src/installer/dracut-module/module-setup.sh | 4 ++--
>  src/installer/hw.c                          | 7 -------
>  src/installer/hw.h                          | 9 ++++-----
>  src/installer/main.c                        | 3 +--
>  4 files changed, 7 insertions(+), 16 deletions(-)
>=20
> diff --git a/src/installer/dracut-module/module-setup.sh b/src/installer/dr=
acut-module/module-setup.sh
> index c68b51d26..26a257cf8 100755
> --- a/src/installer/dracut-module/module-setup.sh
> +++ b/src/installer/dracut-module/module-setup.sh
> @@ -30,8 +30,8 @@ install() {
>      instmods virtio_net hv_netvsc vmxnet3
> =20
>      # Filesystem support
> -    inst_multiple parted mkswap mke2fs mkreiserfs mkfs.xfs mkfs.vfat
> -    instmods ext4 iso9660 reiserfs vfat xfs ntfs3
> +    inst_multiple parted mkswap mke2fs mkfs.xfs mkfs.vfat
> +    instmods ext4 iso9660 vfat xfs ntfs3
> =20
>      # Extraction
>      inst_multiple tar gzip zstd
> diff --git a/src/installer/hw.c b/src/installer/hw.c
> index 17e0bbb01..5aa162266 100644
> --- a/src/installer/hw.c
> +++ b/src/installer/hw.c
> @@ -811,9 +811,6 @@ static int hw_format_filesystem(const char* path, int f=
s, const char* output) {
>  	// Swap
>  	if (fs =3D=3D HW_FS_SWAP) {
>  		snprintf(cmd, sizeof(cmd), "/sbin/mkswap -v1 %s &>/dev/null", path);
> -	// ReiserFS
> -	} else if (fs =3D=3D HW_FS_REISERFS) {
> -		snprintf(cmd, sizeof(cmd), "/sbin/mkreiserfs -f %s ", path);
> =20
>  	// EXT4
>  	} else if (fs =3D=3D HW_FS_EXT4) {
> @@ -878,10 +875,6 @@ int hw_mount_filesystems(struct hw_destination* dest, =
const char* prefix) {
> =20
>  	const char* filesystem;
>  	switch (dest->filesystem) {
> -		case HW_FS_REISERFS:
> -			filesystem =3D "reiserfs";
> -			break;
> -
>  		case HW_FS_EXT4:
>  		case HW_FS_EXT4_WO_JOURNAL:
>  			filesystem =3D "ext4";
> diff --git a/src/installer/hw.h b/src/installer/hw.h
> index b11dfa48f..6a7f23aa7 100644
> --- a/src/installer/hw.h
> +++ b/src/installer/hw.h
> @@ -42,11 +42,10 @@
>  #define HW_PART_TABLE_GPT             1
> =20
>  #define HW_FS_SWAP                    0
> -#define HW_FS_REISERFS                1
> -#define HW_FS_EXT4                    2
> -#define HW_FS_EXT4_WO_JOURNAL         3
> -#define HW_FS_XFS                     4
> -#define HW_FS_FAT32                   5
> +#define HW_FS_EXT4                    1
> +#define HW_FS_EXT4_WO_JOURNAL         2
> +#define HW_FS_XFS                     3
> +#define HW_FS_FAT32                   4
> =20
>  #define HW_FS_DEFAULT                 HW_FS_EXT4
> =20
> diff --git a/src/installer/main.c b/src/installer/main.c
> index b31b096a5..06dd9caf5 100644
> --- a/src/installer/main.c
> +++ b/src/installer/main.c
> @@ -720,7 +720,6 @@ int main(int argc, char *argv[]) {
>  			{ HW_FS_EXT4,            _("ext4 Filesystem") },
>  			{ HW_FS_EXT4_WO_JOURNAL, _("ext4 Filesystem without journal") },
>  			{ HW_FS_XFS,             _("XFS Filesystem") },
> -			{ HW_FS_REISERFS,        _("ReiserFS Filesystem") },
>  			{ 0, NULL },
>  		};
>  		unsigned int num_filesystems =3D sizeof(filesystems) / sizeof(*filesyste=
ms);
> @@ -735,7 +734,7 @@ int main(int argc, char *argv[]) {
>  		}
> =20
>  		rc =3D newtWinMenu(_("Filesystem Selection"), _("Please choose your file=
system:"),
> -			50, 5, 5, 6, fs_names, &fs_choice, _("OK"), _("Cancel"), NULL);
> +			50, 5, 5, 5, fs_names, &fs_choice, _("OK"), _("Cancel"), NULL);
> =20
>  		if (rc =3D=3D 2)
>  			goto EXIT;

--===============1169360252591201362==--