public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: "Peter Müller" <peter.mueller@link38.eu>
To: development@lists.ipfire.org
Subject: Re: [PATCH] remove forgotten Nagios files, if any
Date: Tue, 24 Apr 2018 16:54:49 +0200	[thread overview]
Message-ID: <e98682ee-b3d4-4b20-9758-d12529898327@link38.eu> (raw)
In-Reply-To: <1524562503.1637848.273.camel@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1951 bytes --]

Hello Michael,
> Hey,
> 
> the nagios package should have been removed automatically and remove all program
> files with it. Did you install a testing core update?
At the moment, yes (Core Update 120), but that appeared before, too. Maybe the
dependency to NRPE blocked something from being removed here (issue can be reproduced
on two systems, one of them was never on testing tree).
> 
> Also, Core Update 120 is being packaged and distributed on the servers so far.
> If nothing major needs fixing, I would like to avoid rebuilding this only for
> this patch.
>From my point of view, there is no rush here. I am fine pushing this in Core Update
121. Just want to clean up the disk.

Best regards,
Peter Müller
> 
> Best,
> -Michael
> 
> On Mon, 2018-04-23 at 16:38 +0200, Peter Müller wrote:
>> When we decided to drop Nagios, some files were not removed on the
>> installations. Since the package does not exist anymore, "pakfire remove
>> nagios"
>> does not work so we need to clean them up manually in case they exist.
>>
>> Signed-off-by: Peter Müller <peter.mueller(a)link38.eu>
>> ---
>>  config/rootfiles/core/120/update.sh | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/config/rootfiles/core/120/update.sh
>> b/config/rootfiles/core/120/update.sh
>> index e4ee15b52..310f669c1 100644
>> --- a/config/rootfiles/core/120/update.sh
>> +++ b/config/rootfiles/core/120/update.sh
>> @@ -86,6 +86,12 @@ done
>>  # Remove deprecated SSH configuration option
>>  sed -e "/UsePrivilegeSeparation/d" -i /etc/ssh/sshd_config
>>  
>> +# Remove forgotten Nagios files, if any...
>> +test -f /etc/rc.d/init.d/nagios && rm -f /etc/rc.d/init.d/nagios
>> +test -f /usr/bin/nagios && rm -f /usr/bin/nagios
>> +test -d /usr/share/nagios/ && rm -rf /usr/share/nagios/
>> +test -d /var/nagios/ && rm -rf /var/nagios/
>> +
>>  # Remove any pakfire keys stored in /
>>  rm -rfv /.gnupg
>>  

  reply	other threads:[~2018-04-24 14:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-23 14:38 Peter Müller
2018-04-24  9:35 ` Michael Tremer
2018-04-24 14:54   ` Peter Müller [this message]
2018-04-24 14:58     ` Michael Tremer
2018-04-26 15:17       ` [PATCH v2] " Peter Müller
2018-04-26 17:01         ` Michael Tremer
2018-04-26 17:25           ` Peter Müller
2018-04-26 17:26             ` Michael Tremer
2018-04-26 19:44               ` [PATCH v3] " Peter Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e98682ee-b3d4-4b20-9758-d12529898327@link38.eu \
    --to=peter.mueller@link38.eu \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox