From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter =?utf-8?q?M=C3=BCller?= To: development@lists.ipfire.org Subject: Re: [PATCH] remove forgotten Nagios files, if any Date: Tue, 24 Apr 2018 16:54:49 +0200 Message-ID: In-Reply-To: <1524562503.1637848.273.camel@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0565557006052430992==" List-Id: --===============0565557006052430992== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Michael, > Hey, >=20 > the nagios package should have been removed automatically and remove all pr= ogram > files with it. Did you install a testing core update? At the moment, yes (Core Update 120), but that appeared before, too. Maybe the dependency to NRPE blocked something from being removed here (issue can be re= produced on two systems, one of them was never on testing tree). >=20 > Also, Core Update 120 is being packaged and distributed on the servers so f= ar. > If nothing major needs fixing, I would like to avoid rebuilding this only f= or > this patch. >>From my point of view, there is no rush here. I am fine pushing this in Core= Update 121. Just want to clean up the disk. Best regards, Peter M=C3=BCller >=20 > Best, > -Michael >=20 > On Mon, 2018-04-23 at 16:38 +0200, Peter M=C3=BCller wrote: >> When we decided to drop Nagios, some files were not removed on the >> installations. Since the package does not exist anymore, "pakfire remove >> nagios" >> does not work so we need to clean them up manually in case they exist. >> >> Signed-off-by: Peter M=C3=BCller >> --- >> config/rootfiles/core/120/update.sh | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/config/rootfiles/core/120/update.sh >> b/config/rootfiles/core/120/update.sh >> index e4ee15b52..310f669c1 100644 >> --- a/config/rootfiles/core/120/update.sh >> +++ b/config/rootfiles/core/120/update.sh >> @@ -86,6 +86,12 @@ done >> # Remove deprecated SSH configuration option >> sed -e "/UsePrivilegeSeparation/d" -i /etc/ssh/sshd_config >> =20 >> +# Remove forgotten Nagios files, if any... >> +test -f /etc/rc.d/init.d/nagios && rm -f /etc/rc.d/init.d/nagios >> +test -f /usr/bin/nagios && rm -f /usr/bin/nagios >> +test -d /usr/share/nagios/ && rm -rf /usr/share/nagios/ >> +test -d /var/nagios/ && rm -rf /var/nagios/ >> + >> # Remove any pakfire keys stored in / >> rm -rfv /.gnupg >> =20 --===============0565557006052430992==--