From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH v2] Core Update 170: Harden mount options of /boot on
 existing installations
Date: Thu, 14 Jul 2022 10:15:50 +0000
Message-ID: <e9fc7a97-c975-e32b-e234-e83b3ba6e6dc@ipfire.org>
In-Reply-To: <DE49EB57-0E24-455A-91D2-B767B8ED8576@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2001810631132024998=="
List-Id: <development.lists.ipfire.org>

--===============2001810631132024998==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Michael,

gee, thank you. :-)

Are you otherwise fine with this patch?

Thanks, and best regards,
Peter M=C3=BCller


> Hello,
>=20
> The pointer: https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dblob;f=3Dsrc/in=
staller/hw.c;h=3D12f8e793de49b65afb4d271f10d6d7717e8a8145;hb=3DHEAD#l1125
>=20
> -Michael
>=20
>> On 13 Jul 2022, at 20:48, Peter M=C3=BCller <peter.mueller(a)ipfire.org> w=
rote:
>>
>> Hello *,
>>
>> additionally, we need to ensure /boot mount options are already written wi=
th these flags
>> into /etc/fstab on new installations. For flash-images, this is already do=
ne in C169, but
>> I have yet to investigate where to change things for the ISO files.
>>
>> Any hints would be appreciated. :-)
>>
>> Thanks, and best regards,
>> Peter M=C3=BCller
>>
>>
>>> The second version of this patch uses @ instead of / for sed delimiters,
>>> which makes the command less hard to read. Since Core Update 170 already
>>> requires a reboot at this point, the respective directive is omitted.
>>>
>>> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
>>> ---
>>> config/rootfiles/core/170/update.sh | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/config/rootfiles/core/170/update.sh b/config/rootfiles/core/=
170/update.sh
>>> index 7dde03060..78a4709bc 100644
>>> --- a/config/rootfiles/core/170/update.sh
>>> +++ b/config/rootfiles/core/170/update.sh
>>> @@ -110,6 +110,9 @@ chown nobody:nobody /var/lib/ipblocklist
>>> # Start services
>>> /etc/init.d/rc.d/unbound start
>>>
>>> +# Harden mount options of /boot
>>> +sed -e -i "s@[[:space:]]*\/boot[[:space:]]*auto[[:space:]]*defaults[[:sp=
ace:]]*@ \/boot    auto defaults,nodev,noexec,nosuid   @g" /etc/fstab
>>> +
>>> # This update needs a reboot...
>>> touch /var/run/need_reboot
>>>
>=20

--===============2001810631132024998==--