Re: [PATCH 1/2] procy.cgi: Fix bug#12701 - remove advproxy wpad notice line

["Peter Müller" <peter.mueller@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1439 bytes --]

Hello Adolf,

thank you for this patchset, and no worries whatsoever regarding the timeline. :-)

While the first part of this patchset looks good to me, the changes made to en.pl
in the second part look odd: Instead of removing a single translation, it seems to
bring back an older state of this file - perhaps thanks due to some orphaned version
that was locally present during development.

Could you please double-check the second patch? If necessary, feel free to just send
that one in - I'll merge the first part in due course, so there is no need to resubmit
the entire series.

Thanks, and best regards,
Peter Müller


> - This line is no longer needed with the help button at the top of each WUI page that was
>    implemented by @Leo
> - Sorry for long time for me to get around to finalising this patch but it is done now.
> 
> Fixes: bug#12701
> Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
>  html/cgi-bin/proxy.cgi | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/html/cgi-bin/proxy.cgi b/html/cgi-bin/proxy.cgi
> index b4073343e..a718d5771 100644
> --- a/html/cgi-bin/proxy.cgi
> +++ b/html/cgi-bin/proxy.cgi
> @@ -1421,9 +1421,6 @@ print <<END
>  <tr>
>  	<td colspan="4">&nbsp;</td>
>  </tr>
> -<tr>
> -	<td colspan="4">$Lang::tr{'advproxy wpad notice'}</td>
> -</tr>
>  </table>
>  
>  <hr size='1'>