From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/9] ipsec-interfaces: Don't throw away errors when
 creating routes
Date: Fri, 10 May 2024 17:21:53 +0200
Message-ID: <ec41bbe8-6d7b-4485-b4d4-6081747b0ff2@ipfire.org>
In-Reply-To: <20240510120234.995049-1-michael.tremer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3128180029457601002=="
List-Id: <development.lists.ipfire.org>

--===============3128180029457601002==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Adolf Belka <adolf.belka(a)ipfire.org>

On 10/05/2024 14:02, Michael Tremer wrote:
> This partly reverts 87a97a431915849cf6d19e1b7137b4fb0b6dd91d.
>
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
>   src/scripts/ipsec-interfaces | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/scripts/ipsec-interfaces b/src/scripts/ipsec-interfaces
> index 974d3ac84..b05b2009c 100644
> --- a/src/scripts/ipsec-interfaces
> +++ b/src/scripts/ipsec-interfaces
> @@ -115,7 +115,7 @@ main() {
>   	# We are done when IPsec is not enabled
>   	if [ "${ENABLED}" =3D "on" ]; then
>   		# Enable route table lookup
> -		ip rule add lookup "${ROUTE_TABLE}" prio "${ROUTE_TABLE_PRIO}" >/dev/nul=
l 2>&1
> +		ip rule add lookup "${ROUTE_TABLE}" prio "${ROUTE_TABLE_PRIO}"
>  =20
>   		while IFS=3D"," read -r "${VARS[@]}"; do
>   			# Check if the connection is enabled
> @@ -158,7 +158,7 @@ main() {
>  =20
>   						log "Creating route to ${rightsubnet} (via ${address} and ${RED_INT=
F})"
>   						ip route add table "${ROUTE_TABLE}" "${rightsubnet}" proto static \
> -							dev "${RED_INTF}" src "${address}" >/dev/null 2>&1
> +							dev "${RED_INTF}" src "${address}"
>   					done
>  =20
>   					# No interface processing required

--===============3128180029457601002==--