From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Fischer To: development@lists.ipfire.org Subject: Re: diagrams - all over the CGIs Date: Wed, 13 May 2020 16:14:16 +0200 Message-ID: In-Reply-To: <83755B15-1C34-4BE9-8F6E-6FEC2B1220C0@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7814750266669457365==" List-Id: --===============7814750266669457365== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Done. And something more... On 13.05.2020 11:59, Michael Tremer wrote: > Hi, >=20 >> On 13 May 2020, at 09:38, Matthias Fischer = wrote: >>=20 >> Hi, >>=20 >> this just came to my view while looking at Peters patches for >> 'system.cgi' and 'graphs.pl' ("properly translate load average graph"). >>=20 >> Searching for the translation string ...$Lang::tr{'graph'}... I found >> it twenty-two(!) times - only in '/srv/web/ipfire/cgi-bin/*'. >>=20 >> What are these repetitions good for? >>=20 >> I mean, you click on "Network (external)". You read the topic >> "Net-Traffic graphs (external)" or "... (internal). >>=20 >> You know: here I'll find ... graphs. Ok. Lets see. >>=20 >> But why is there "red0 *Graph*", green0 *Graph*", "blue0 *Graph*", or >> CPU *Graph* / CPU frequency *Graph*, Memory *Graph*, Swap *Graph*, sda >> *Graph*, ACPI Thermal-Zone Temp *Graph* - over and over again? >=20 > Yeah, we absolutely do not need that word in the headline. >=20 > =E2=80=9CMemory=E2=80=9D should make it clear what we are showing. It is ob= vious that the graph is a graph. >=20 >> My two cents: I think we don't need this translation string at these >> specific points in the WUI. >=20 > Would you like to send in a patch for this? >=20 > Best, > -Michael >=20 >>=20 >> Opinions? >>=20 >> Best, >> Matthias >=20 --===============7814750266669457365==--