From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/3] services.cgi: minor cosmetics
Date: Mon, 03 Oct 2022 20:40:07 +0200
Message-ID: <eca2b213-e5ab-d4a2-661c-ce2204b77dce@ipfire.org>
In-Reply-To: <20221003153905.14824-2-robin.roevens@disroot.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2708265631155087833=="
List-Id: <development.lists.ipfire.org>

--===============2708265631155087833==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>

Am 03.10.2022 um 17:39 schrieb Robin Roevens:
> * Singular 'Service' instead of plural 'Services' as column header of
>    services table
> * Sort list of services
> 
> Signed-off-by: Robin Roevens <robin.roevens(a)disroot.org>
> ---
>   html/cgi-bin/services.cgi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/html/cgi-bin/services.cgi b/html/cgi-bin/services.cgi
> index e91da884b..d480088a8 100644
> --- a/html/cgi-bin/services.cgi
> +++ b/html/cgi-bin/services.cgi
> @@ -105,7 +105,7 @@ if ( $querry[0] =~ "processescpu"){
>   <div align='center'>
>   <table width='80%' cellspacing='1' class='tbl'>
>   <tr>
> -	<th align='left'><b>$Lang::tr{'services'}</b></th>
> +	<th align='left'><b>$Lang::tr{'service'}</b></th>
>   	<th align='center' ><b>$Lang::tr{'status'}</b></th>
>   	<th align='center'><b>PID</b></th>
>   	<th align='center'><b>$Lang::tr{'memory'}</b></th>
> @@ -167,7 +167,7 @@ END
>   	# Generate list of installed addon pak services
>   	my %paklist = &Pakfire::dblist("installed");
>   
> -	foreach my $pak (keys %paklist) {
> +	foreach my $pak (sort keys %paklist) {
>   		my %metadata = &Pakfire::getmetadata($pak, "installed");
>   			
>   		my $service;

--===============2708265631155087833==--