Re: [PATCH 1/2] perl-libnet: Provides replacement for deprecated perl-Net-SMTP-SSL

[Adolf Belka <adolf.belka@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 6144 bytes --]

Hi Michael,

On 25/03/2021 10:42, Michael Tremer wrote:
> Hello,
> 
> This patch looks good, but I was wondering if we do not want to ship all (sub-)modules that are in here?
They seem a quite diverse range of modules not needed for using SMTP. 
The only one I am not sure about is Net::Cmd but the rest seem 
independent of using SMTP.
Net::Cmd		Network Command class (as used by FTP, SMTP etc)
Net::Config		Local configuration data for libnet
Net::Domain		Attempt to evaluate the current host's internet name and domain
Net::FTP		FTP Client class
Net::FTP::dataconn	FTP Client data connection class
Net::NNTP		NNTP Client class
Net::Netrc		OO interface to users netrc file
Net::POP3		Post Office Protocol 3 Client class (RFC1939)
Net::SMTP		Simple Mail Transfer Protocol Client
Net::Time		time and daytime network client interface

> 
> Does it work with only shipping that one file?
I have only been able to test that the build worked. I don't have a 
working git system in my testbed IPFire so I can't test operation. If 
you or one of the other Devs can test if it works then we can see if 
there are problems. I can easily rebuild and add in the other modules if 
it turns out that they are needed. However I was reticent about making 
available FTP, NTP, Netrc and POP perl modules in IPFire addon if they 
are not really needed.
If it is believed that they should be added I am fine to redo the build 
with all modules.

Regards,
Adolf.
> 
> -Michael
> 
>> On 24 Mar 2021, at 11:37, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>
>> - libnet is a collection of perl5 modules which all relate to network
>>    programming.
>> - perl-libnet is replacing perl-Net-SMTP-SSL as a dependency for git
>>    The only module being installed from perl-libnet is Net-SMTP
>>    Since Net::SMTP v1.28 (2014-10-08), Net::SMTP itself has support for
>>     SMTP over SSL, and also for STARTTLS
>> - Recommendation of the maintainer of module Net-SMTP-SSL is to use
>>    Net-SMTP and Net-SMTP-SSL has been deprecated.
>> - Remove perl-Net-SMTP-SSL from make.sh and replace with perl-libnet
>> - Remove perl-Net-SMTP-SSL rootfile
>> - Create perl-libnet rootfile
>>
>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>> ---
>> config/rootfiles/packages/perl-Net-SMTP-SSL |  6 ------
>> config/rootfiles/packages/perl-libnet       | 19 +++++++++++++++++++
>> lfs/{perl-Net-SMTP-SSL => perl-libnet}      | 10 +++++-----
>> make.sh                                     |  2 +-
>> 4 files changed, 25 insertions(+), 12 deletions(-)
>> delete mode 100644 config/rootfiles/packages/perl-Net-SMTP-SSL
>> create mode 100644 config/rootfiles/packages/perl-libnet
>> rename lfs/{perl-Net-SMTP-SSL => perl-libnet} (95%)
>>
>> diff --git a/config/rootfiles/packages/perl-Net-SMTP-SSL b/config/rootfiles/packages/perl-Net-SMTP-SSL
>> deleted file mode 100644
>> index 1ac5584f7..000000000
>> --- a/config/rootfiles/packages/perl-Net-SMTP-SSL
>> +++ /dev/null
>> @@ -1,6 +0,0 @@
>> -#usr/lib/perl5/site_perl/5.30.0/Net/SMTP
>> -usr/lib/perl5/site_perl/5.30.0/Net/SMTP/SSL.pm
>> -#usr/lib/perl5/site_perl/5.30.0/xxxMACHINExxx-linux-thread-multi/auto/Net/SMTP
>> -#usr/lib/perl5/site_perl/5.30.0/xxxMACHINExxx-linux-thread-multi/auto/Net/SMTP/SSL
>> -#usr/lib/perl5/site_perl/5.30.0/xxxMACHINExxx-linux-thread-multi/auto/Net/SMTP/SSL/.packlist
>> -#usr/share/man/man3/Net::SMTP::SSL.3
>> diff --git a/config/rootfiles/packages/perl-libnet b/config/rootfiles/packages/perl-libnet
>> new file mode 100644
>> index 000000000..ffe788da0
>> --- /dev/null
>> +++ b/config/rootfiles/packages/perl-libnet
>> @@ -0,0 +1,19 @@
>> +#usr/lib/perl5/site_perl/5.30.0/Net/Cmd.pm
>> +#usr/lib/perl5/site_perl/5.30.0/Net/Config.pm
>> +#usr/lib/perl5/site_perl/5.30.0/Net/Domain.pm
>> +#usr/lib/perl5/site_perl/5.30.0/Net/FTP
>> +#usr/lib/perl5/site_perl/5.30.0/Net/FTP.pm
>> +#usr/lib/perl5/site_perl/5.30.0/Net/FTP/A.pm
>> +#usr/lib/perl5/site_perl/5.30.0/Net/FTP/E.pm
>> +#usr/lib/perl5/site_perl/5.30.0/Net/FTP/I.pm
>> +#usr/lib/perl5/site_perl/5.30.0/Net/FTP/L.pm
>> +#usr/lib/perl5/site_perl/5.30.0/Net/FTP/dataconn.pm
>> +#usr/lib/perl5/site_perl/5.30.0/Net/NNTP.pm
>> +#usr/lib/perl5/site_perl/5.30.0/Net/Netrc.pm
>> +#usr/lib/perl5/site_perl/5.30.0/Net/POP3.pm
>> +usr/lib/perl5/site_perl/5.30.0/Net/SMTP.pm
>> +#usr/lib/perl5/site_perl/5.30.0/Net/Time.pm
>> +#usr/lib/perl5/site_perl/5.30.0/Net/libnet.cfg
>> +#usr/lib/perl5/site_perl/5.30.0/Net/libnetFAQ.pod
>> +#usr/lib/perl5/site_perl/5.30.0/xxxMACHINExxx-linux-thread-multi/auto/Net/.packlist
>> +#usr/share/man/man3/Net::FTP::dataconn.3
>> diff --git a/lfs/perl-Net-SMTP-SSL b/lfs/perl-libnet
>> similarity index 95%
>> rename from lfs/perl-Net-SMTP-SSL
>> rename to lfs/perl-libnet
>> index 2bb00a808..27e716f82 100644
>> --- a/lfs/perl-Net-SMTP-SSL
>> +++ b/lfs/perl-libnet
>> @@ -24,16 +24,16 @@
>>
>> include Config
>>
>> -VER        = 1.04
>> +VER        = 3.13
>>
>> -THISAPP    = Net-SMTP-SSL-$(VER)
>> +THISAPP    = libnet-$(VER)
>> DL_FILE    = ${THISAPP}.tar.gz
>> DL_FROM    = $(URL_IPFIRE)
>> DIR_APP    = $(DIR_SRC)/$(THISAPP)
>> TARGET     = $(DIR_INFO)/$(THISAPP)
>> -PROG       = perl-Net-SMTP-SSL
>> +PROG       = perl-libnet
>> DEPS       =
>> -PAK_VER    = 3
>> +PAK_VER    = 1
>>
>> ###############################################################################
>> # Top-level Rules
>> @@ -43,7 +43,7 @@ objects = $(DL_FILE)
>>
>> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>>
>> -$(DL_FILE)_MD5 = 62b49c961043898b43b041dafbc1b389
>> +$(DL_FILE)_MD5 = 3fa5c6989db687b2381cd42fe55f5134
>>
>> install : $(TARGET)
>>
>> diff --git a/make.sh b/make.sh
>> index 0c124ac81..8d2e0bfc5 100755
>> --- a/make.sh
>> +++ b/make.sh
>> @@ -1499,7 +1499,7 @@ buildipfire() {
>>    lfsmake2 libmpdclient
>>    lfsmake2 mpc
>>    lfsmake2 perl-Net-CIDR-Lite
>> -  lfsmake2 perl-Net-SMTP-SSL
>> +  lfsmake2 perl-libnet
>>    lfsmake2 perl-MIME-Base64
>>    lfsmake2 perl-Authen-SASL
>>    lfsmake2 perl-MIME-Lite
>> -- 
>> 2.31.0
>>
> 

-- 
Sent from my laptop