From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] netother.cgi: show content of routing table 220
Date: Sun, 08 Mar 2020 13:15:00 +0000
Message-ID: <ed593e05-e25f-ec0a-9e9f-af55c44dc914@ipfire.org>
In-Reply-To: <36253712-E143-4794-84DA-A74562317C38@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3765757400467255173=="
List-Id: <development.lists.ipfire.org>

--===============3765757400467255173==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Michael,

> Hi,
>=20
> I appreciate the thought, but I think the implementation might be very conf=
using.
>=20
> I think the patch could be improved by:
>=20
> * Removing the 220 number and simply call it =E2=80=9CIPsec VPN Routing Tab=
le=E2=80=9D

Okay, good point.

>=20
> * Not show the box when the table is empty which it will be for all users t=
hat are not using IPsec

ACK.

>=20
> And since it is basically a static table, I do not see what there is to gai=
n for the user from this. How can this help with debugging?

For the same reasons we display contents of the routing table, I guess. The u=
ser is
able to do quick plausibility checks over it, without digging/using the search
engine of his/hers least distrust for the command that shows him the IPsec ro=
uting information.

Thanks, and best regards,
Peter M=C3=BCller

>=20
> -Michael
>=20
>> On 7 Mar 2020, at 18:46, Peter M=C3=BCller <peter.mueller(a)ipfire.org> wr=
ote:
>>
>> Since IPsec routing information do not show up in the normal routing
>> table, also displaying the contents of table 220 on netother.cgi might
>> be useful for debugging purposes.
>>
>> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
>> ---
>> html/cgi-bin/netother.cgi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/html/cgi-bin/netother.cgi b/html/cgi-bin/netother.cgi
>> index dde1b603a..ac02b8148 100644
>> --- a/html/cgi-bin/netother.cgi
>> +++ b/html/cgi-bin/netother.cgi
>> @@ -79,6 +79,12 @@ if ( $querry[0] =3D~ "fwhits"){
>> 	print "<pre>$output</pre>\n";
>> 	&Header::closebox();
>>
>> +	&Header::openbox('100%', 'left', "$Lang::tr{'routing table entries'} 220=
");
>> +	$output =3D `/sbin/ip route list table 220`;
>> +	$output =3D &Header::cleanhtml($output,"y");
>> +	print "<pre>$output</pre>\n";
>> +	&Header::closebox()
>> +
>> 	&Header::openbox('100%', 'left', $Lang::tr{'arp table entries'});
>> 	$output =3D `/sbin/ip neigh show`;
>> 	$output =3D &Header::cleanhtml($output,"y");
>> --=20
>> 2.16.4
>=20

--===============3765757400467255173==--