From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthias Fischer <matthias.fischer@ipfire.org>
To: development@lists.ipfire.org
Subject:
 Re: Aw: GUI for WLanAP doesn't reflect current settings for 'noscan' option
Date: Sat, 09 Mar 2019 21:15:56 +0100
Message-ID: <ee0a2acf-f287-385b-4bf7-8cec0c781301@ipfire.org>
In-Reply-To:
 <trinity-2140f025-1c98-4e5c-84d6-b5d3a8c17e8c-1552160914554@3c-app-gmx-bs17>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8725212664935358694=="
List-Id: <development.lists.ipfire.org>

--===============8725212664935358694==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

HI,

On 09.03.2019 20:48, Bernhard Bitsch wrote:
>=20
>=20
>> Gesendet: Samstag, 09. M=C3=A4rz 2019 um 18:54 Uhr
>> Von: "Matthias Fischer" <matthias.fischer(a)ipfire.org>
>> An: "IPFire: Development-List" <development(a)lists.ipfire.org>
>> Betreff: GUI for WLanAP doesn't reflect current settings for 'noscan' opti=
on
>>
>> Hi,
>>=20
>> could someone please take a look at:
>>=20
>> https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dcommit;h=3Dd823d5f07211e984=
489027d57c49ae16db66c7f2
>>=20
>> Especially (line 423):
>> https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dblob;f=3Dhtml/cgi-bin/wlana=
p.cgi;h=3D72c9a129828fb845ddc654313854b57d85b3489c;hb=3Dd823d5f07211e98448902=
7d57c49ae16db66c7f2
>>=20
>> The WLanAP-GUI always shows the radio button as checked to ON, no matter
>> what I choose.
>>=20
>> Can anyone confirm?
>>=20
> Cannot confirm this. The WUI just shows the last saved stated as checked.=20
> Switch to off / save --> off is checked
> Switch to on / save  --> on is checked
>=20
> Best,
> Bernhard

Thanks for the feedback, but that is strange.

To get it working as expected, I had to change line 423 from:

<tr><td width=3D'25%' class=3D'base'>$Lang::tr{'wlanap neighbor scan'}:&nbsp;=
</td><td class=3D'base' >on <input type=3D'radio' name=3D'NOSCAN' value=3D'of=
f' $checked{'NOSCAN'}{'off'} /> | <input type=3D'radio' name=3D'NOSCAN' value=
=3D'on' $checked{'NOSCAN'}{'on'} /> off</td><td class=3D'base' colspan=3D'2'>=
$Lang::tr{'wlanap neighbor scan warning'}</td></tr>

To:

<tr><td width=3D'25%' class=3D'base'>$Lang::tr{'wlanap neighbor scan'}:&nbsp;=
</td><td class=3D'base' >on <input type=3D'radio' name=3D'NOSCAN' value=3D'on=
' $checked{'NOSCAN'}{'on'} /> | <input type=3D'radio' name=3D'NOSCAN' value=
=3D'off' $checked{'NOSCAN'}{'off'} /> off</td><td class=3D'base' colspan=3D'2=
'>$Lang::tr{'wlanap neighbor scan warning'}</td></tr>

Don't know if I'm just puzzled, but whatever I did, ON remained checked.

Will take a closer look again.

Best,
Matthias

--===============8725212664935358694==--