* GUI for WLanAP doesn't reflect current settings for 'noscan' option
@ 2019-03-09 17:54 Matthias Fischer
2019-03-09 19:48 ` Aw: " Bernhard Bitsch
0 siblings, 1 reply; 6+ messages in thread
From: Matthias Fischer @ 2019-03-09 17:54 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 535 bytes --]
Hi,
could someone please take a look at:
https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=d823d5f07211e984489027d57c49ae16db66c7f2
Especially (line 423):
https://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=html/cgi-bin/wlanap.cgi;h=72c9a129828fb845ddc654313854b57d85b3489c;hb=d823d5f07211e984489027d57c49ae16db66c7f2
The WLanAP-GUI always shows the radio button as checked to ON, no matter
what I choose.
Can anyone confirm?
Best,
Matthias
--
tails, linux, USB, CD, secure desktop, IRC, truecrypt, tor, onion
^ permalink raw reply [flat|nested] 6+ messages in thread
* Aw: GUI for WLanAP doesn't reflect current settings for 'noscan' option
2019-03-09 17:54 GUI for WLanAP doesn't reflect current settings for 'noscan' option Matthias Fischer
@ 2019-03-09 19:48 ` Bernhard Bitsch
2019-03-09 20:15 ` Matthias Fischer
0 siblings, 1 reply; 6+ messages in thread
From: Bernhard Bitsch @ 2019-03-09 19:48 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]
> Gesendet: Samstag, 09. März 2019 um 18:54 Uhr
> Von: "Matthias Fischer" <matthias.fischer(a)ipfire.org>
> An: "IPFire: Development-List" <development(a)lists.ipfire.org>
> Betreff: GUI for WLanAP doesn't reflect current settings for 'noscan' option
>
> Hi,
>
> could someone please take a look at:
>
> https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=d823d5f07211e984489027d57c49ae16db66c7f2
>
> Especially (line 423):
> https://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=html/cgi-bin/wlanap.cgi;h=72c9a129828fb845ddc654313854b57d85b3489c;hb=d823d5f07211e984489027d57c49ae16db66c7f2
>
> The WLanAP-GUI always shows the radio button as checked to ON, no matter
> what I choose.
>
> Can anyone confirm?
>
Cannot confirm this. The WUI just shows the last saved stated as checked.
Switch to off / save --> off is checked
Switch to on / save --> on is checked
Best,
Bernhard
> Best,
> Matthias
> --
> tails, linux, USB, CD, secure desktop, IRC, truecrypt, tor, onion
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Aw: GUI for WLanAP doesn't reflect current settings for 'noscan' option
2019-03-09 19:48 ` Aw: " Bernhard Bitsch
@ 2019-03-09 20:15 ` Matthias Fischer
2019-03-09 20:59 ` Matthias Fischer
0 siblings, 1 reply; 6+ messages in thread
From: Matthias Fischer @ 2019-03-09 20:15 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1932 bytes --]
HI,
On 09.03.2019 20:48, Bernhard Bitsch wrote:
>
>
>> Gesendet: Samstag, 09. März 2019 um 18:54 Uhr
>> Von: "Matthias Fischer" <matthias.fischer(a)ipfire.org>
>> An: "IPFire: Development-List" <development(a)lists.ipfire.org>
>> Betreff: GUI for WLanAP doesn't reflect current settings for 'noscan' option
>>
>> Hi,
>>
>> could someone please take a look at:
>>
>> https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=d823d5f07211e984489027d57c49ae16db66c7f2
>>
>> Especially (line 423):
>> https://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=html/cgi-bin/wlanap.cgi;h=72c9a129828fb845ddc654313854b57d85b3489c;hb=d823d5f07211e984489027d57c49ae16db66c7f2
>>
>> The WLanAP-GUI always shows the radio button as checked to ON, no matter
>> what I choose.
>>
>> Can anyone confirm?
>>
> Cannot confirm this. The WUI just shows the last saved stated as checked.
> Switch to off / save --> off is checked
> Switch to on / save --> on is checked
>
> Best,
> Bernhard
Thanks for the feedback, but that is strange.
To get it working as expected, I had to change line 423 from:
<tr><td width='25%' class='base'>$Lang::tr{'wlanap neighbor scan'}: </td><td class='base' >on <input type='radio' name='NOSCAN' value='off' $checked{'NOSCAN'}{'off'} /> | <input type='radio' name='NOSCAN' value='on' $checked{'NOSCAN'}{'on'} /> off</td><td class='base' colspan='2'>$Lang::tr{'wlanap neighbor scan warning'}</td></tr>
To:
<tr><td width='25%' class='base'>$Lang::tr{'wlanap neighbor scan'}: </td><td class='base' >on <input type='radio' name='NOSCAN' value='on' $checked{'NOSCAN'}{'on'} /> | <input type='radio' name='NOSCAN' value='off' $checked{'NOSCAN'}{'off'} /> off</td><td class='base' colspan='2'>$Lang::tr{'wlanap neighbor scan warning'}</td></tr>
Don't know if I'm just puzzled, but whatever I did, ON remained checked.
Will take a closer look again.
Best,
Matthias
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Aw: GUI for WLanAP doesn't reflect current settings for 'noscan' option
2019-03-09 20:15 ` Matthias Fischer
@ 2019-03-09 20:59 ` Matthias Fischer
2019-03-09 21:19 ` Aw: " Bernhard Bitsch
0 siblings, 1 reply; 6+ messages in thread
From: Matthias Fischer @ 2019-03-09 20:59 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1640 bytes --]
Hi Bernhard,
On 09.03.2019 21:15, Matthias Fischer wrote:
> ...
>>> Can anyone confirm?
>>>
>> Cannot confirm this. The WUI just shows the last saved stated as checked.
>> Switch to off / save --> off is checked
>> Switch to on / save --> on is checked
Hm.
Could you please check the resulting values for ON and OFF settings?
Here:
wlanap.cgi - ON is checked:
/var/ipfire/wlanap/hostapd.conf => noscan=1
/var/ipfire/wlanap/settings => NOSCAN=on
wlanap.cgi - OFF is checked:
/var/ipfire/wlanap/hostapd.conf => noscan=0
/var/ipfire/wlanap/settings => NOSCAN=OFF
Do you get the same results?
Best,
Matthias
>> Best,
>> Bernhard
>
> Thanks for the feedback, but that is strange.
>
> To get it working as expected, I had to change line 423 from:
>
> <tr><td width='25%' class='base'>$Lang::tr{'wlanap neighbor scan'}: </td><td class='base' >on <input type='radio' name='NOSCAN' value='off' $checked{'NOSCAN'}{'off'} /> | <input type='radio' name='NOSCAN' value='on' $checked{'NOSCAN'}{'on'} /> off</td><td class='base' colspan='2'>$Lang::tr{'wlanap neighbor scan warning'}</td></tr>
>
> To:
>
> <tr><td width='25%' class='base'>$Lang::tr{'wlanap neighbor scan'}: </td><td class='base' >on <input type='radio' name='NOSCAN' value='on' $checked{'NOSCAN'}{'on'} /> | <input type='radio' name='NOSCAN' value='off' $checked{'NOSCAN'}{'off'} /> off</td><td class='base' colspan='2'>$Lang::tr{'wlanap neighbor scan warning'}</td></tr>
>
> Don't know if I'm just puzzled, but whatever I did, ON remained checked.
>
> Will take a closer look again.
>
> Best,
> Matthias
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Aw: Re: GUI for WLanAP doesn't reflect current settings for 'noscan' option
2019-03-09 20:59 ` Matthias Fischer
@ 2019-03-09 21:19 ` Bernhard Bitsch
2019-03-09 22:21 ` Matthias Fischer
0 siblings, 1 reply; 6+ messages in thread
From: Bernhard Bitsch @ 2019-03-09 21:19 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 2347 bytes --]
Hi Matthias,
> Gesendet: Samstag, 09. März 2019 um 21:59 Uhr
> Von: "Matthias Fischer" <matthias.fischer(a)ipfire.org>
> An: "Bernhard Bitsch" <Bernhard.Bitsch(a)gmx.de>, "IPFire Development" <development(a)lists.ipfire.org>
> Betreff: Re: Aw: GUI for WLanAP doesn't reflect current settings for 'noscan' option
>
> Hi Bernhard,
>
> On 09.03.2019 21:15, Matthias Fischer wrote:
> > ...
> >>> Can anyone confirm?
> >>>
> >> Cannot confirm this. The WUI just shows the last saved stated as checked.
> >> Switch to off / save --> off is checked
> >> Switch to on / save --> on is checked
>
> Hm.
>
> Could you please check the resulting values for ON and OFF settings?
>
> Here:
>
> wlanap.cgi - ON is checked:
> /var/ipfire/wlanap/hostapd.conf => noscan=1
> /var/ipfire/wlanap/settings => NOSCAN=on
>
> wlanap.cgi - OFF is checked:
> /var/ipfire/wlanap/hostapd.conf => noscan=0
> /var/ipfire/wlanap/settings => NOSCAN=OFF
>
> Do you get the same results?
>
> Best,
> Matthias
>
No, it's just the other way. Just as the original line reads, I think.
I also checked the functionality. If I check "Neighbourhood scan=off" hostapd generates a 40MHZ signal, and vice versa.
The semantics are ok also: "Neighbour scan=off" --> scan --> noscan=0.
Best,
Bernhard
> >> Best,
> >> Bernhard
> >
> > Thanks for the feedback, but that is strange.
> >
> > To get it working as expected, I had to change line 423 from:
> >
> > <tr><td width='25%' class='base'>$Lang::tr{'wlanap neighbor scan'}: </td><td class='base' >on <input type='radio' name='NOSCAN' value='off' $checked{'NOSCAN'}{'off'} /> | <input type='radio' name='NOSCAN' value='on' $checked{'NOSCAN'}{'on'} /> off</td><td class='base' colspan='2'>$Lang::tr{'wlanap neighbor scan warning'}</td></tr>
> >
> > To:
> >
> > <tr><td width='25%' class='base'>$Lang::tr{'wlanap neighbor scan'}: </td><td class='base' >on <input type='radio' name='NOSCAN' value='on' $checked{'NOSCAN'}{'on'} /> | <input type='radio' name='NOSCAN' value='off' $checked{'NOSCAN'}{'off'} /> off</td><td class='base' colspan='2'>$Lang::tr{'wlanap neighbor scan warning'}</td></tr>
> >
> > Don't know if I'm just puzzled, but whatever I did, ON remained checked.
> >
> > Will take a closer look again.
> >
> > Best,
> > Matthias
> >
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Aw: Re: GUI for WLanAP doesn't reflect current settings for 'noscan' option
2019-03-09 21:19 ` Aw: " Bernhard Bitsch
@ 2019-03-09 22:21 ` Matthias Fischer
0 siblings, 0 replies; 6+ messages in thread
From: Matthias Fischer @ 2019-03-09 22:21 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]
Hi Bernhard,
On 09.03.2019 22:19, Bernhard Bitsch wrote:
> ...
>> On 09.03.2019 21:15, Matthias Fischer wrote:
>> > ...
>> Could you please check the resulting values for ON and OFF settings?
>>
>> Here:
>>
>> wlanap.cgi - ON is checked:
>> /var/ipfire/wlanap/hostapd.conf => noscan=1
>> /var/ipfire/wlanap/settings => NOSCAN=on
>>
>> wlanap.cgi - OFF is checked:
>> /var/ipfire/wlanap/hostapd.conf => noscan=0
>> /var/ipfire/wlanap/settings => NOSCAN=OFF
>>
>> Do you get the same results?
>>
>> Best,
>> Matthias
>>
>
> No, it's just the other way. Just as the original line reads, I think.
> I also checked the functionality. If I check "Neighbourhood scan=off" hostapd generates a 40MHZ signal, and vice versa.
> The semantics are ok also: "Neighbour scan=off" --> scan --> noscan=0.
Ok, I think I mixed this up somehow before. After correcting the above line back to original I get:
wlanap.cgi - ON is checked:
/var/ipfire/wlanap/hostapd.conf => noscan=0
/var/ipfire/wlanap/settings => NOSCAN=off
wlanap.cgi - OFF is checked:
/var/ipfire/wlanap/hostapd.conf => noscan=1
/var/ipfire/wlanap/settings => NOSCAN=on
And the appropriate choice remains checked. Duh!
Correct!?
Best,
Matthias
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-09 22:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-09 17:54 GUI for WLanAP doesn't reflect current settings for 'noscan' option Matthias Fischer
2019-03-09 19:48 ` Aw: " Bernhard Bitsch
2019-03-09 20:15 ` Matthias Fischer
2019-03-09 20:59 ` Matthias Fischer
2019-03-09 21:19 ` Aw: " Bernhard Bitsch
2019-03-09 22:21 ` Matthias Fischer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox