Restarting dhcp or adding a host leads to "could not parse line"-errors in '/var/log messages'

Restarting dhcp or adding a host leads to "could not parse line"-errors in '/var/log messages'

[Matthias Fischer]

[-- Attachment #1: Type: text/plain, Size: 2918 bytes --]

Hi,

Sorry, but we're at it again...

DHCP-Configuration:
No addresspool, only fixed leases, working fine, no problems during
operation. And I mean it. NO problems! All clients are operational.

But a few days after adding a new host to fixed leases, I stumbled upon
a whole lot of error lines in '/var/log/messages'. One host, one line.

***SNIP***
dhcp[3480]: Could not parse line: on,[HOSTADRESS],[HOSTNAME],localdomain,on
***SNAP***

Today I tested this on a testmachine with a fresh install (Core 134):

- Activated dhcp (dhcp.cgi), added two fixed leases, just for fun.
- Added one host (hosts.cgi), page reloads and stays "Waiting for ...".
- Added second host (hosts,cgi), page reloads and stays "Waiting for
..." and the new host is not shown. No errors in
'/var/log/httpd/error_log/'!

- After playing a while with the testmachine I looked at
'/var/log/messages' and found a lot of 'could not parse line' errors
again. One error line for each host. Seems to be the same on my
production machine. ;-(

***SNIP***
dhcp[3480]: Could not parse line: on,192.168.100.50,test1,localdomain,on
dhcp[3480]: Could not parse line: on,192.168.100.50,test1,localdomain,on
dhcp[3480]: Could not parse line: on,192.168.100.50,test1,localdomain,on
dhcp[3480]: Could not parse line: on,192.168.100.50,test1,localdomain,on
dhcp[3480]: Could not parse line: on,192.168.100.50,test,localdomain,on
dhcp[3480]: Could not parse line: on,192.168.100.50,test1,localdomain,on
dhcp[3480]: Could not parse line: on,192.168.100.50,test,localdomain,on
dhcp[3480]: Could not parse line: on,192.168.100.51,test1,localdomain,on
dhcp[3480]: Could not parse line: on,192.168.100.50,test,localdomain,on
dhcp[3480]: Could not parse line: on,192.168.100.51,test1,localdomain,on
dhcp[3480]: Could not parse line: on,192.168.100.50,test,localdomain,on
dhcp[3480]: Could not parse line: on,192.168.100.51,test1,localdomain,on
dhcp[3480]: Could not parse line: on,192.168.100.53,test3,localdomain,on
***SNAP***

And this happens every time I restart 'dhcp' or add/edit a host.

Current '/var/ipfire/main/hosts' on testmachine contains:

***SNIP***
on,192.168.100.50,test0,localdomain,on
on,192.168.100.51,test1,localdomain,on
on,192.168.100.52,test2,localdomain,on
***SNAP***

Restarting 'dhcp' or editing a host gives me (e.g):

***SNIP***
11:06:50 dhcpd: Wrote 0 deleted host decls to leases file.
11:06:50 dhcpd: Wrote 0 new dynamic host decls to leases file.
11:06:50 dhcpd: Wrote 0 leases to leases file.
11:06:50 dhcpd: Server starting service.
11:06:50 dhcp[9159]: Could not parse line:
on,192.168.100.50,test0,localdomain,on
11:06:50 dhcp[9159]: Could not parse line:
on,192.168.100.51,test1,localdomain,on
11:06:50 dhcp[9159]: Could not parse line:
on,192.168.100.52,test2,localdomain,on
***SNAP***

'dhcp' and fixed leases are working though!

Can anyone confirm or has a hint were to look? I didn't find a grip on
this yet.

Best,
Matthias

Re: Restarting dhcp or adding a host leads to "could not parse line"-errors in '/var/log messages'

[Matthias Fischer]

[-- Attachment #1: Type: text/plain, Size: 3443 bytes --]

Hi,

I reverted:

https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=c3c2ae4475a0e99a6163027405a45a1e2b4fa8b6

and

https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=6874a5765b887b51e324e1afbddc4516d66a710f

Errors are gone.

On 13.07.2019 10:20, Matthias Fischer wrote:
> Hi,
> 
> Sorry, but we're at it again...
> 
> DHCP-Configuration:
> No addresspool, only fixed leases, working fine, no problems during
> operation. And I mean it. NO problems! All clients are operational.
> 
> But a few days after adding a new host to fixed leases, I stumbled upon
> a whole lot of error lines in '/var/log/messages'. One host, one line.
> 
> ***SNIP***
> dhcp[3480]: Could not parse line: on,[HOSTADRESS],[HOSTNAME],localdomain,on
> ***SNAP***
> 
> Today I tested this on a testmachine with a fresh install (Core 134):
> 
> - Activated dhcp (dhcp.cgi), added two fixed leases, just for fun.
> - Added one host (hosts.cgi), page reloads and stays "Waiting for ...".
> - Added second host (hosts,cgi), page reloads and stays "Waiting for
> ..." and the new host is not shown. No errors in
> '/var/log/httpd/error_log/'!
> 
> - After playing a while with the testmachine I looked at
> '/var/log/messages' and found a lot of 'could not parse line' errors
> again. One error line for each host. Seems to be the same on my
> production machine. ;-(
> 
> ***SNIP***
> dhcp[3480]: Could not parse line: on,192.168.100.50,test1,localdomain,on
> dhcp[3480]: Could not parse line: on,192.168.100.50,test1,localdomain,on
> dhcp[3480]: Could not parse line: on,192.168.100.50,test1,localdomain,on
> dhcp[3480]: Could not parse line: on,192.168.100.50,test1,localdomain,on
> dhcp[3480]: Could not parse line: on,192.168.100.50,test,localdomain,on
> dhcp[3480]: Could not parse line: on,192.168.100.50,test1,localdomain,on
> dhcp[3480]: Could not parse line: on,192.168.100.50,test,localdomain,on
> dhcp[3480]: Could not parse line: on,192.168.100.51,test1,localdomain,on
> dhcp[3480]: Could not parse line: on,192.168.100.50,test,localdomain,on
> dhcp[3480]: Could not parse line: on,192.168.100.51,test1,localdomain,on
> dhcp[3480]: Could not parse line: on,192.168.100.50,test,localdomain,on
> dhcp[3480]: Could not parse line: on,192.168.100.51,test1,localdomain,on
> dhcp[3480]: Could not parse line: on,192.168.100.53,test3,localdomain,on
> ***SNAP***
> 
> And this happens every time I restart 'dhcp' or add/edit a host.
> 
> Current '/var/ipfire/main/hosts' on testmachine contains:
> 
> ***SNIP***
> on,192.168.100.50,test0,localdomain,on
> on,192.168.100.51,test1,localdomain,on
> on,192.168.100.52,test2,localdomain,on
> ***SNAP***
> 
> Restarting 'dhcp' or editing a host gives me (e.g):
> 
> ***SNIP***
> 11:06:50 dhcpd: Wrote 0 deleted host decls to leases file.
> 11:06:50 dhcpd: Wrote 0 new dynamic host decls to leases file.
> 11:06:50 dhcpd: Wrote 0 leases to leases file.
> 11:06:50 dhcpd: Server starting service.
> 11:06:50 dhcp[9159]: Could not parse line:
> on,192.168.100.50,test0,localdomain,on
> 11:06:50 dhcp[9159]: Could not parse line:
> on,192.168.100.51,test1,localdomain,on
> 11:06:50 dhcp[9159]: Could not parse line:
> on,192.168.100.52,test2,localdomain,on
> ***SNAP***
> 
> 'dhcp' and fixed leases are working though!
> 
> Can anyone confirm or has a hint were to look? I didn't find a grip on
> this yet.
> 
> Best,
> Matthias
> 

Re: Restarting dhcp or adding a host leads to "could not parse line"-errors in '/var/log messages'

[Matthias Fischer]

[-- Attachment #1: Type: text/plain, Size: 3677 bytes --]

Filed as Bug #12115:

https://bugzilla.ipfire.org/show_bug.cgi?id=12115

On 13.07.2019 12:57, Matthias Fischer wrote:
> Hi,
> 
> I reverted:
> 
> https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=c3c2ae4475a0e99a6163027405a45a1e2b4fa8b6
> 
> and
> 
> https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=6874a5765b887b51e324e1afbddc4516d66a710f
> 
> Errors are gone.
> 
> On 13.07.2019 10:20, Matthias Fischer wrote:
>> Hi,
>> 
>> Sorry, but we're at it again...
>> 
>> DHCP-Configuration:
>> No addresspool, only fixed leases, working fine, no problems during
>> operation. And I mean it. NO problems! All clients are operational.
>> 
>> But a few days after adding a new host to fixed leases, I stumbled upon
>> a whole lot of error lines in '/var/log/messages'. One host, one line.
>> 
>> ***SNIP***
>> dhcp[3480]: Could not parse line: on,[HOSTADRESS],[HOSTNAME],localdomain,on
>> ***SNAP***
>> 
>> Today I tested this on a testmachine with a fresh install (Core 134):
>> 
>> - Activated dhcp (dhcp.cgi), added two fixed leases, just for fun.
>> - Added one host (hosts.cgi), page reloads and stays "Waiting for ...".
>> - Added second host (hosts,cgi), page reloads and stays "Waiting for
>> ..." and the new host is not shown. No errors in
>> '/var/log/httpd/error_log/'!
>> 
>> - After playing a while with the testmachine I looked at
>> '/var/log/messages' and found a lot of 'could not parse line' errors
>> again. One error line for each host. Seems to be the same on my
>> production machine. ;-(
>> 
>> ***SNIP***
>> dhcp[3480]: Could not parse line: on,192.168.100.50,test1,localdomain,on
>> dhcp[3480]: Could not parse line: on,192.168.100.50,test1,localdomain,on
>> dhcp[3480]: Could not parse line: on,192.168.100.50,test1,localdomain,on
>> dhcp[3480]: Could not parse line: on,192.168.100.50,test1,localdomain,on
>> dhcp[3480]: Could not parse line: on,192.168.100.50,test,localdomain,on
>> dhcp[3480]: Could not parse line: on,192.168.100.50,test1,localdomain,on
>> dhcp[3480]: Could not parse line: on,192.168.100.50,test,localdomain,on
>> dhcp[3480]: Could not parse line: on,192.168.100.51,test1,localdomain,on
>> dhcp[3480]: Could not parse line: on,192.168.100.50,test,localdomain,on
>> dhcp[3480]: Could not parse line: on,192.168.100.51,test1,localdomain,on
>> dhcp[3480]: Could not parse line: on,192.168.100.50,test,localdomain,on
>> dhcp[3480]: Could not parse line: on,192.168.100.51,test1,localdomain,on
>> dhcp[3480]: Could not parse line: on,192.168.100.53,test3,localdomain,on
>> ***SNAP***
>> 
>> And this happens every time I restart 'dhcp' or add/edit a host.
>> 
>> Current '/var/ipfire/main/hosts' on testmachine contains:
>> 
>> ***SNIP***
>> on,192.168.100.50,test0,localdomain,on
>> on,192.168.100.51,test1,localdomain,on
>> on,192.168.100.52,test2,localdomain,on
>> ***SNAP***
>> 
>> Restarting 'dhcp' or editing a host gives me (e.g):
>> 
>> ***SNIP***
>> 11:06:50 dhcpd: Wrote 0 deleted host decls to leases file.
>> 11:06:50 dhcpd: Wrote 0 new dynamic host decls to leases file.
>> 11:06:50 dhcpd: Wrote 0 leases to leases file.
>> 11:06:50 dhcpd: Server starting service.
>> 11:06:50 dhcp[9159]: Could not parse line:
>> on,192.168.100.50,test0,localdomain,on
>> 11:06:50 dhcp[9159]: Could not parse line:
>> on,192.168.100.51,test1,localdomain,on
>> 11:06:50 dhcp[9159]: Could not parse line:
>> on,192.168.100.52,test2,localdomain,on
>> ***SNAP***
>> 
>> 'dhcp' and fixed leases are working though!
>> 
>> Can anyone confirm or has a hint were to look? I didn't find a grip on
>> this yet.
>> 
>> Best,
>> Matthias
>> 
> 
> 

[PATCH] unbound-dhcp-leases-bridge: handle PTR generation parameter

[Peter Müller]

[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]

Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
Reported-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
---
 config/rootfiles/core/135/filelists/files | 1 +
 config/unbound/unbound-dhcp-leases-bridge | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/config/rootfiles/core/135/filelists/files b/config/rootfiles/core/135/filelists/files
index 780d4aef5..3d868d324 100644
--- a/config/rootfiles/core/135/filelists/files
+++ b/config/rootfiles/core/135/filelists/files
@@ -9,3 +9,4 @@ etc/rc.d/init.d/functions
 etc/rc.d/init.d/partresize
 etc/rc.d/init.d/unbound
 etc/sysctl.conf
+usr/sbin/unbound-dhcp-leases-bridge
diff --git a/config/unbound/unbound-dhcp-leases-bridge b/config/unbound/unbound-dhcp-leases-bridge
index a8cd837bb..64306bc9b 100644
--- a/config/unbound/unbound-dhcp-leases-bridge
+++ b/config/unbound/unbound-dhcp-leases-bridge
@@ -153,7 +153,7 @@ class UnboundDHCPLeasesBridge(object):
 				line = line.rstrip()
 
 				try:
-					enabled, ipaddr, hostname, domainname = line.split(",")
+					enabled, ipaddr, hostname, domainname, generateptr = line.split(",")
 				except:
 					log.warning("Could not parse line: %s" % line)
 					continue
-- 
2.16.4