From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] misc-progs: Set a reasonable default PATH variable
Date: Mon, 21 Mar 2022 19:11:53 +0000
Message-ID: <f0553850-2670-3469-7a0b-f256041af667@ipfire.org>
In-Reply-To: <20220321190706.2969988-1-michael.tremer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6901256213783435782=="
List-Id: <development.lists.ipfire.org>

--===============6901256213783435782==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>

> We have some scripts in /usr/local/bin which cannot be found by any
> misc-progs which is fixed by this patch.
> 
> Fixes: #12811
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
>  src/misc-progs/setuid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/misc-progs/setuid.c b/src/misc-progs/setuid.c
> index 8044742f2..831fb1f90 100644
> --- a/src/misc-progs/setuid.c
> +++ b/src/misc-progs/setuid.c
> @@ -46,7 +46,7 @@
>  
>  /* Trusted environment for executing commands */
>  char * trusted_env[4] = {
> -	"PATH=/usr/bin:/usr/sbin:/sbin:/bin",
> +	"PATH=/usr/local/bin:/usr/local/sbin:/sbin:/usr/sbin:/bin:/usr/bin",
>  	"SHELL=/bin/sh",
>  	"TERM=dumb",
>  	NULL

--===============6901256213783435782==--