From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] pakfire: Fix small bug: wrong pak count on list
Date: Fri, 16 Jul 2021 09:36:33 +0200 [thread overview]
Message-ID: <f0e3be3e-b8aa-6ae1-f47e-a4dd9588dc07@ipfire.org> (raw)
In-Reply-To: <20210624220700.14161-1-robin.roevens@disroot.org>
[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]
Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
Tested-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
Am 25.06.2021 um 00:07 schrieb Robin Roevens:
> Fixes pakfire list installed/notinstalled command displaying the
> count of all available paks instead of the count of actual installed
> respectively not installed paks.
>
> Signed-off-by: Robin Roevens <robin.roevens(a)disroot.org>
> ---
> src/pakfire/lib/functions.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/pakfire/lib/functions.pl b/src/pakfire/lib/functions.pl
> index f9a19b60d..c15e54f94 100644
> --- a/src/pakfire/lib/functions.pl
> +++ b/src/pakfire/lib/functions.pl
> @@ -512,13 +512,13 @@ sub dblist {
> foreach $line (sort @db) {
> next unless ($line =~ /.*;.*;.*;/ );
> $use_color = "";
> - $count++;
> @templine = split(/\;/,$line);
> if ("$filter" eq "notinstalled") {
> next if ( -e "$Conf::dbdir/installed/meta-$templine[0]" );
> } elsif ("$filter" eq "installed") {
> next unless ( -e "$Conf::dbdir/installed/meta-$templine[0]" );
> }
> + $count++;
> if ("$forweb" eq "forweb")
> {
> if ("$filter" eq "notinstalled") {
>
next prev parent reply other threads:[~2021-07-16 7:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 22:07 Robin Roevens
2021-07-16 7:36 ` Bernhard Bitsch [this message]
2021-07-16 10:50 ` Michael Tremer
2022-01-30 21:13 ` Robin Roevens
[not found] <f6cb78551c3c88a957ca2ac70c23d34ee0bfdc0d.camel@sicho.home>
2022-02-07 10:46 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0e3be3e-b8aa-6ae1-f47e-a4dd9588dc07@ipfire.org \
--to=bbitsch@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox