From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: libnfnetlink and libmnl Date: Thu, 07 Apr 2022 13:19:04 +0200 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7311528870948021431==" List-Id: --===============7311528870948021431== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Michael & *, Building without libart libdnet libpri libsolv pigz sdparm went without any problems. I have submitted a patch set removing them from IP= Fire. libnet needs to stay as arping requires it. libaio is needed by lvm2. However when I looked at lvm2 in IPFire it is not a= ctually used by IPFire at all. The commands are all available but there are n= o mapped volume groups , logical groups etc. Is lvm2 provided so that people can use logical volumes on additional hard di= sks that might be mounted on IPFire. Presumably if people have already create= d lvm structures on other disk drives on the IPFire hardware then we need to = stay with lvm2 being present otherwise its removal would stop people being ab= le to access that additional hard disk(s). If that is the case then libaio will also need to stay. Regards, Adolf. On 06/04/2022 19:02, Michael Tremer wrote: > Hello, >=20 >> On 6 Apr 2022, at 17:52, Adolf Belka wrote: >> >> Hi Michael, >> >> On 06/04/2022 17:38, Adolf Belka wrote: >>> Hi Michael, >>> >>> On 06/04/2022 16:42, Michael Tremer wrote: >>>> Hello Adolf, >>>> >>>>> On 6 Apr 2022, at 14:18, Adolf Belka wrote: >>>>> >>>>> Hi All, >>>>> >>>>> We have both libnfnetlink and libmnl in IPFire. I have just done an upd= ate of libmnl. >>>>> There is an update of libnfnetlink but it also says that libnfnetlink i= s still deprecated and should preferably be replaced by libmnl >>>> >>>> Oh this is very interesting. >>>> >>>> It looks like libmnl was introduced for conntrack-tools in this commit: >>>> >>>> commit a10733a5d8580b6ab8cff46235daab6547723781 >>>> Author: Arne Fitzenreiter >>>> Date: Thu Jan 3 14:27:11 2013 +0100 >>>> >>>> conntrack-tools: add conntrack and needed deps. >>>> >>>> You can try to comment out libnfnetlink and libmnl and run a clean build= and see if it goes through. If so, then we can safely drop them. >>>> >> It didn't go clean. It looks like libnetfilter_queue requires both libmnl = and libnfnetlink for compiling/building different parts of libnetfilter_queue= . I don't know if it is required for running but it wouldn't surprise me so b= oth these will have to stay. >> >> It's interesting that the group that says libmnl should be used in prefere= nce to libnfnetlink then go and require both to still be used for one of thei= r programs. >=20 > Well, we all have good intentions to keep our software clean, but very ofte= n there is some legacy bit that everyone relies on and simply never gets clea= ned up. >=20 >> I will continue looking through other files that you highlighted. >=20 > Thank you. >=20 >> >> >> Regards, >> >> Adolf. >> >>>>> I have run ./make.sh find-dependencies on both libmnl.so.0.2.0 and libn= fnetlink.so.0.2.0 and neither came up with anything. Doing a grep on the git = repository for mnl or nfnetlink also didn't indicate anything using these. >>>>> How are they being used and what needs to be done to change the usage o= f libnfnetlink to libmnl? >>>> >>>> See above. >>>> >>>> I believe there are a couple of other candidates for this which we shoul= d have a look at. There is libdnet that I noticed a little while ago, but I a= m sure there will be plenty more when looking through the package list: >>>> >>>> libaio >>>> libart >>>> libnet >>>> libnl (and if something depends on it, can it not use libnl-3?) >>>> libpri (if I remember correctly this was a dependency of asterisk) >>>> libsolv can absolutely go for the moment, we don=E2=80=99t need it >>>> netpbm? >>>> pigz (we don=E2=80=99t use it anywhere since we are compressing images w= ith XZ b302b9a695e391477eab0cb2343f3ba1b1ba1989) >>>> sdparm >>>> >>>> If you have the time, maybe you can have a look at what is used somewher= e and what can be dropped? >>> I will give that a go and use your inputs as starting points. >>> >>> Regards, >>> Adolf >>>> >>>> This won=E2=80=99t shrink the distribution by a massive amount, but why = should we carry around dead code? >>>> >>>> Best, >>>> -Michael >>>> >>>>> Regards, >>>>> Adolf >=20 --===============7311528870948021431==--