Re: [PATCH] BUG11695: Adding/editing rules with preset broken

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]

Hello,

what are we doing about systems that already have some value in the external
port setting?

-Michael

On Thu, 2018-05-24 at 14:26 +0200, Alexander Marx wrote:
> added another check to fill same ports in source and destination when a custom
> service is selected.
> 
> Signed-off-by: Alexander Marx <alexander.marx(a)ipfire.org>
> Reported-by: erik(a)vanlinsteeict.nl
> ---
>  html/cgi-bin/firewall.cgi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/html/cgi-bin/firewall.cgi b/html/cgi-bin/firewall.cgi
> index 499f279..d17afab 100644
> --- a/html/cgi-bin/firewall.cgi
> +++ b/html/cgi-bin/firewall.cgi
> @@ -757,6 +757,7 @@ sub checkrule
>  				}
>  			}
>  			if($fwdfwsettings{'nat'} eq 'dnat' &&
> $fwdfwsettings{'dnatport'} eq ''){$fwdfwsettings{'dnatport'}=$custsrvport;}
> +			if($fwdfwsettings{'nat'} eq 'dnat' &&
> $fwdfwsettings{'grp3'} eq
> 'cust_srv'){$fwdfwsettings{'dnatport'}=$custsrvport;}
>  		}
>  		#check if DNAT port is multiple
>  		if($fwdfwsettings{'nat'} eq 'dnat' &&
> $fwdfwsettings{'dnatport'} ne ''){