From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] BUG11695: Adding/editing rules with preset broken
Date: Thu, 24 May 2018 15:47:04 +0100
Message-ID: <f1f9e4966cbd31da00c09eb1b642f02de701f7b6.camel@ipfire.org>
In-Reply-To: <1527164764-17533-1-git-send-email-alexander.marx@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8959629922942557648=="
List-Id: <development.lists.ipfire.org>

--===============8959629922942557648==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

what are we doing about systems that already have some value in the external
port setting?

-Michael

On Thu, 2018-05-24 at 14:26 +0200, Alexander Marx wrote:
> added another check to fill same ports in source and destination when a cus=
tom
> service is selected.
>=20
> Signed-off-by: Alexander Marx <alexander.marx(a)ipfire.org>
> Reported-by: erik(a)vanlinsteeict.nl
> ---
>  html/cgi-bin/firewall.cgi | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/html/cgi-bin/firewall.cgi b/html/cgi-bin/firewall.cgi
> index 499f279..d17afab 100644
> --- a/html/cgi-bin/firewall.cgi
> +++ b/html/cgi-bin/firewall.cgi
> @@ -757,6 +757,7 @@ sub checkrule
>  				}
>  			}
>  			if($fwdfwsettings{'nat'} eq 'dnat' &&
> $fwdfwsettings{'dnatport'} eq ''){$fwdfwsettings{'dnatport'}=3D$custsrvport=
;}
> +			if($fwdfwsettings{'nat'} eq 'dnat' &&
> $fwdfwsettings{'grp3'} eq
> 'cust_srv'){$fwdfwsettings{'dnatport'}=3D$custsrvport;}
>  		}
>  		#check if DNAT port is multiple
>  		if($fwdfwsettings{'nat'} eq 'dnat' &&
> $fwdfwsettings{'dnatport'} ne ''){

--===============8959629922942557648==--