From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/4] unbound-dhcp-leases-bridge: Don't export expired leases to Unbound
Date: Mon, 21 Oct 2024 18:42:48 +0200 [thread overview]
Message-ID: <f356faa3-7cc4-4fd6-b9e1-363e426b3665@ipfire.org> (raw)
In-Reply-To: <20241021163849.1265183-1-michael.tremer@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 877 bytes --]
Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
Am 21.10.2024 um 18:38 schrieb Michael Tremer:
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
> config/unbound/unbound-dhcp-leases-bridge | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/config/unbound/unbound-dhcp-leases-bridge b/config/unbound/unbound-dhcp-leases-bridge
> index 986fae2d2..bc944a073 100644
> --- a/config/unbound/unbound-dhcp-leases-bridge
> +++ b/config/unbound/unbound-dhcp-leases-bridge
> @@ -276,7 +276,7 @@ class UnboundDHCPLeasesBridge(object):
> if lease.has_expired():
> log.debug(" Expired")
>
> - self.unbound.update_dhcp_leases(self.leases)
> + self.unbound.update_dhcp_leases([l for l in self.leases if not l.has_expired()])
>
> def _add_lease(self, lease):
> # Skip leases without an FQDN
prev parent reply other threads:[~2024-10-21 16:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 16:38 Michael Tremer
2024-10-21 16:38 ` [PATCH 2/4] unbound-dhcp-leases-bridge: Fix typo Michael Tremer
2024-10-21 16:44 ` Bernhard Bitsch
2024-10-21 16:38 ` [PATCH 3/4] unbound-dhcp-leases-bridge: Don't overwrite static leases Michael Tremer
2024-10-21 16:47 ` Bernhard Bitsch
2024-10-21 16:38 ` [PATCH 4/4] unbound-dhcp-leases-bridge: Fix expiry check on leases Michael Tremer
2024-10-21 16:42 ` Bernhard Bitsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f356faa3-7cc4-4fd6-b9e1-363e426b3665@ipfire.org \
--to=bbitsch@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox