From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/4] unbound-dhcp-leases-bridge: Don't export expired
 leases to Unbound
Date: Mon, 21 Oct 2024 18:42:48 +0200
Message-ID: <f356faa3-7cc4-4fd6-b9e1-363e426b3665@ipfire.org>
In-Reply-To: <20241021163849.1265183-1-michael.tremer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3563067003128132189=="
List-Id: <development.lists.ipfire.org>

--===============3563067003128132189==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>

Am 21.10.2024 um 18:38 schrieb Michael Tremer:
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
>   config/unbound/unbound-dhcp-leases-bridge | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/config/unbound/unbound-dhcp-leases-bridge b/config/unbound/unb=
ound-dhcp-leases-bridge
> index 986fae2d2..bc944a073 100644
> --- a/config/unbound/unbound-dhcp-leases-bridge
> +++ b/config/unbound/unbound-dhcp-leases-bridge
> @@ -276,7 +276,7 @@ class UnboundDHCPLeasesBridge(object):
>   				if lease.has_expired():
>   					log.debug("    Expired")
>  =20
> -		self.unbound.update_dhcp_leases(self.leases)
> +		self.unbound.update_dhcp_leases([l for l in self.leases if not l.has_exp=
ired()])
>  =20
>   	def _add_lease(self, lease):
>   		# Skip leases without an FQDN


--===============3563067003128132189==--