From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH] embed background image in redirect template Date: Sun, 17 Jun 2018 15:04:41 +0100 Message-ID: In-Reply-To: <51c2a554-d56a-0764-7240-5f3de90bce5a@link38.eu> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6913519185697921064==" List-Id: --===============6913519185697921064== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hello, although I generally agree with the fix, this is not the best solution. When ever the image file is changed, this needs to be manually changed, too. That's not nice. It would be better to read the image file when rendering the HTML output and encoding it into base64 on the fly. Best, - -Michael On Sat, 2018-06-16 at 20:48 +0200, Peter M=C3=BCller wrote: > Embed the IPFire background image into the redirect template > directly via CSS instead of loading it from somewhere else. >=20 > This is necessary because of Content Security Policy (CSP) and > fixes #11650. >=20 > Signed-off-by: Peter M=C3=BCller > --- > html/html/redirect-templates/legacy/template.html | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) >=20 > diff --git a/html/html/redirect-templates/legacy/template.html > b/html/html/redirect-templates/legacy/template.html > index b5fb61ebe..8a6a563a3 100644 > --- a/html/html/redirect-templates/legacy/template.html > +++ b/html/html/redirect-templates/legacy/template.html > @@ -3,11 +3,17 @@ > > charset=3Dutf-8">=20 > ACCESS MESSAGE > + > > > > > - > >
align=3D"center" background=3D"/images/backgroun= d.gif"> > + align=3D"center" class=3D"image"> 
> width=3D'80%'> -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE5/rW5l3GGe2ypktxgHnw/2+QCQcFAlsmankACgkQgHnw/2+Q CQdhPg//Wnzp6NyjKgGjFhn/k7pwY5WmaTNf7trU9AesNd0yeyLs3NMNiPqQpPVY 2zXHXuAdwYZr6zVFkpV2YtI3y4dolA5DL3tN9B18QvcXSaffpVCTJeG7Rh/6+6pz E5WcPFRM2SlTgfx2ORdfslFjRwMyQGaod4S7hV4xmFMhaxpGA3uh9h5S3eAu9hJq 5m4e1T+YnY0A2Gja40F23rJ5G4fRj9jhane456/I0yMsaI7khWtIPRgYb6SCY8uE VlHL1/6xgT9XVLkln3vNAUXsy7lN5Kh/JQfEXqtL2oOas4jUbiQhRrX5d3Lc7YR+ HYFbjnutlhLEP00HMcCxCZ8K0kdcP/wgHkATCbnwbGP0EiG4O3gSf/nJR+2kPpjg 9aNIJs8RFgrrQ4XdhUh297aBgKQWIoUBeM9FbWzhCHMOvfqiDGHldHOTZdylXi/P bJgUm+uws03ssivkFln3rdKPo2Xa90IE4alOnktdmwGqDuOgoCZl7p6R5l9ULV5J sTCBMHBpwzPwLjIAg7OvqrjF4OxGGUjsZWYE2pfytQsY6rB4+7+XhsBx+Snq2TMF v9Jl4qDVjscV3CCw6XL7d/Q4sdudyEBJgiCkNbG8IVN8pTKuUehnWQbK8t7aIqRJ b63BGSWGhnI49xl2ypicXiztnzJBrmfYHsUYaApboJWM4d0eqnA=3D =3D6diG -----END PGP SIGNATURE----- --===============6913519185697921064==--