From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: AW: Creation of an add-on whose sources are already available in the build system
Date: Sun, 28 Nov 2021 23:32:32 +0100 [thread overview]
Message-ID: <f433da75-8d15-c393-27bd-1a12b069cf32@ipfire.org> (raw)
In-Reply-To: <002001d7e479$8acc9cc0$a065d640$@v16.de>
[-- Attachment #1: Type: text/plain, Size: 1514 bytes --]
Hi Marcel,
On 28/11/2021 18:01, smooky(a)v16.de wrote:
>
> Hi Adolf.
>
> Sorry, but I overlooked qemu-ga in the qemu addon.
>
> But since I only need the qemu-ga when I run ipfire virtualized without the complete qemu, it would make a lot of sense to provide this as a separate add-on.
>
If this is also the case for all users, that the qemu-ga is always needed separately from qemu, then it would make sense to have a separate addon for qemu-ga.
>
> It would not make sense to run a virtualization again on a virtualized system.
>
> How about that?
>
> So to create two addons from one source.
>
> Maybe it would make sense then not to deliver the qemu-ga in the qemu addon because the qemu-ga is only interesting for the virtualized clients but not for the host.
>
So then my suggestion would be to comment out in the qemu addon rootfile the qemu-ga entry.
Then I would suggest to create an additional lfs called qemu-ga, based on the qemu lfs. Probably remove some the last lines that are creating a wrapper for kvm handling and the udev script. Then create a qemu-ga rootfile, based on the qemu rootfile but with everything commented out except the qemu-ga line and any of the /usr/share/entries that might be required for qemu-ga. That way you have two addons that deal separately with qemu and with qemu-ga.
The above would be how I would try and approach it. You would basically need to give it a go and see if it works or not.
Regards,
Adolf.
> Regards
>
> Marcel
>
parent reply other threads:[~2021-11-28 22:32 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <002001d7e479$8acc9cc0$a065d640$@v16.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f433da75-8d15-c393-27bd-1a12b069cf32@ipfire.org \
--to=adolf.belka@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox