From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthias Fischer <matthias.fischer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] vnstat 2.6: Fix for lfs
Date: Sun, 12 Apr 2020 19:22:00 +0200
Message-ID: <f5fb9c45-2d9d-7e90-2e88-78e69a1a56dd@ipfire.org>
In-Reply-To: <0625C429-1906-4D46-8F32-319BB3F9E9D1@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1473653568031544268=="
List-Id: <development.lists.ipfire.org>

--===============1473653568031544268==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On 12.04.2020 16:15, Michael Tremer wrote:
>> ...
>> Current link is (I updated the one above!):
>> https://git.ipfire.org/?p=3Dpeople/mfischer/ipfire-2.x.git;a=3Dblob;f=3Dsr=
c/initscripts/system/vnstat;h=3Dc1bb2942a897e0a4acab344c8e2c128d4542f958;hb=
=3D59b3afd07f55b93f4c96bfe63d0506494a46b5ff
>
> So in this script, when you remove line 23 and 33, you will still see OK.

To make this clear to me:

First:
Line 23 contains 'evaluate_retval' after 'loadproc...vnstat'. This is
counterproductive, because...:

> That is being printed in loadproc. evaluate_retval will now always overwrit=
e what loadproc has printed to the right hand side of the console.

Ok, understood. I'll delete line 23.

Second:
'evaluate_retval' in line 33 (umount_ramdisk ...) is similar with line
23. Here the output of evaluate_retval' would overwrite error messages
regarding the unmounting of the ramdisk.(?)

But: in this case I can't see where the [OK] should come from (see
above: "...you will still see OK") when I remove line 33, because I'll
see only the output of 'boot_msg'!?

Would be ok for me, I'll delete line 33, too - I'm just wondering.

> We want to see any errors here

Me, too. ;-)

Best,
Matthias

--===============1473653568031544268==--