From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernhard Bitsch To: development@lists.ipfire.org Subject: Re: [PATCH 1/2] wio.pl: Fix bug 12799 - Remove code scanning for all potential IP's on RED interface Date: Wed, 13 Apr 2022 10:55:46 +0200 Message-ID: In-Reply-To: <20220413080020.3664760-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6501872592026537475==" List-Id: --===============6501872592026537475== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bernhard Bitsch Am 13.04.2022 um 10:00 schrieb Adolf Belka: > - The lines to scan the red interface were introduced at the time of a patc= h to remove > the IPFire start/stop function from wio. These lines are not related to= that change > but were included in the patch with no commit message. The same lines w= ere also added > into wio.cgi in the same patch set but in that case the lines were all = commented out. > - These lines look like they were most likely added to the code for investi= gation or > debugging purposes. Looking at the lines in wio.pl the results obtained= are not > used elsewhere in wio for obtaining info on the status of the red inter= face. Deleting > the lines did not affect anything related to the scanning, setup or mon= itoring of > systems by wio. > - The lines were wasting space but generally not creating a huge impact on = pertformance. > On my production system it scans my red and comes up with a list of 102= 2 IP's because > of the subnet my ISP uses - xxx.yy.216.0/20 > - Scanning those 1022 IP's and sorting them takes my system about 3 seconds= . Without > sorting it is around the same level. > - In Bug#12799 the originator has an ISP that is using a private network th= at has a > defined subnet of 10.0.0.0/8 This is 16,777,214 IP's to be scanned. Eve= n without sorting > my system would end up taking around 13 hours to do that. The bug origi= nator found that > on certain machines that he had IPFire on wio just never stopped scanni= ng. > - As these lines just seem to collect a large amount of IP's on red that ar= e not related > to the actual running red IP, as there was no commit message related to= their > introduction and as removing the lines on vm's running dhcp and static = red interfaces > and also on my running production system for 4 weeks has shown no impac= t on the > monitoring capability this patch is being submitted to remove these lin= es from wio >=20 > Fixes: Bug#12799 > Tested-by: Adolf Belka > Signed-off-by: Adolf Belka > --- > src/wio/main/wio.pl | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/src/wio/main/wio.pl b/src/wio/main/wio.pl > index 91c6c1494..78c91eeb9 100644 > --- a/src/wio/main/wio.pl > +++ b/src/wio/main/wio.pl > @@ -98,9 +98,6 @@ my ( $ping_i, $ping_t, $ping_ib, $ping_tb, $ping_iv, $pin= g_tv, $pingmode ) =3D ''; > my ( @tmp, @arptmp, @myarray, @status, @arpclients ) =3D ''; > my @ifaces =3D ('GREEN','BLUE','ORANGE'); > =20 > -if ( $netsettings{'RED_TYPE'} eq 'STATIC' || $netsettings{'RED_TYPE'} eq '= DHCP' ) { > - push (@ifaces, "RED"); > -} > =20 > if ( $mailsettings{'USEMAIL'} eq 'on' ) { $mailen =3D 'on'; } > else { $mailen =3D 'off'; } --===============6501872592026537475==--