From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: [PATCH] time.cgi: add current date-time to this WebGUI page Date: Thu, 14 Mar 2024 17:35:46 +0100 Message-ID: In-Reply-To: <42CFDCD2-4793-45CD-AEDF-380B02F9B02A@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6025541871733737604==" List-Id: --===============6025541871733737604== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Jon, On 14/03/2024 16:48, jon wrote: > Michael - is this good to go?? > > Jon > > >> On Mar 12, 2024, at 11:18 AM, jon wrote: >> >> Back when I was playing with NTP and tried to make it better in 2022 I tho= ught it would have been helpful but it wasn=E2=80=99t my focus and I did not = have the skills to add it. =C2=A0Recently there were mentions about adding da= te/time in the community. =C2=A0So it seemed like a good time to add (no pun = intended). >> >> Jon Murphy >> jon.murphy(a)ipfire.org >> >> >> >>> On Mar 12, 2024, at 5:10 AM, Michael Tremer = wrote: >>> >>> Hello Jon, >>> >>> What is the motivation for this patch? >>> >>> -Michael >>> >>>> On 11 Mar 2024, at 23:45, Jon Murphy wrote: >>>> >>>> - added words and date-time format to english (en.pl) >>>> - other languages are needed >>>> - seconds included since time is accurate to < .1s I think this could be an issue. The time might be accurate to 0.1 secs but it= will only be updated when the browser page is refreshed. So I can imagine pe= ople saying that the clock is not working because the seconds haven't changed. I have had that sort of problem in the past with the Connections Status page = where people complained that the Connection expiry time was not updating unle= ss they refreshed the browser page and they were sure it used to update every= second in the past. Certainly don't want to be ending up refreshing the browser page every second= or less to show a change in the seconds value. People will likely have a clock on the status panel of their OS desktop anywa= y so if the time matches on the hours and the minutes it will likely match th= e seconds as well. Regards, Adolf. >>>> https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dcommit;h=3D2234e8aacac2e0= d0b06dac4513585c15c2b3b440 >>>> >>>> Code-by: Leo-Andres Hofmann >>>> Signed-off-by: Jon Murphy >>>> --- >>>> html/cgi-bin/time.cgi =C2=A0| 4 ++++ >>>> langs/en/cgi-bin/en.pl | 2 ++ >>>> 2 files changed, 6 insertions(+) >>>> >>>> diff --git a/html/cgi-bin/time.cgi b/html/cgi-bin/time.cgi >>>> index 57a02a4b6..04c1e771f 100644 >>>> --- a/html/cgi-bin/time.cgi >>>> +++ b/html/cgi-bin/time.cgi >>>> @@ -287,6 +287,10 @@ print <>>> >>>> END >>>> ; >>>> + >>>> +my $now =3D strftime($Lang::tr{'timeformat'}, localtime); >>>> +print "
$Lang::tr{'system time'}: $now"; >>>> + >>>> &Header::closebox(); >>>> &Header::openbox('100%',1,$Lang::tr{'ntp sync'}); >>>> print <>>> diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl >>>> index 667fb5d7e..2e036adb3 100644 >>>> --- a/langs/en/cgi-bin/en.pl >>>> +++ b/langs/en/cgi-bin/en.pl >>>> @@ -2462,6 +2462,7 @@ >>>> 'system log viewer' =3D> 'System Log Viewer', >>>> 'system logs' =3D> 'System Logs', >>>> 'system status information' =3D> 'System Status Information', >>>> +'system time' =3D> 'System time (as of last page load)', >>>> 'ta key' =3D> 'TLS-Authentification-Key', >>>> 'taa zombieload2' =3D> 'TSX Async Abort/ZombieLoad v2', >>>> 'tcp more reliable' =3D> 'TCP (more reliable)', >>>> @@ -2490,6 +2491,7 @@ >>>> 'time' =3D> 'Time', >>>> 'time date manually reset' =3D> 'Time/Date manually reset.', >>>> 'time server' =3D> 'Time Server', >>>> +'timeformat' =3D> '%Y-%m-%d at %H:%M:%S %Z', >>>> 'timeout must be a number' =3D> 'Timeout must be a number.', >>>> 'title' =3D> 'Title', >>>> 'to' =3D> 'To', >>>> --=20 >>>> 2.30.2 >>>> >>> >> > --===============6025541871733737604==--