From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: [PATCH] Core Update 171: Ship libsodium Date: Tue, 27 Sep 2022 14:29:47 +0200 Message-ID: In-Reply-To: <9B307A13-3D4F-4B73-8D94-F463B0BA7B2C@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3075069242319494565==" List-Id: --===============3075069242319494565== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Michael & Peter, On 27/09/2022 10:16, Michael Tremer wrote: > Hello Adolf, >=20 > Sorry, I overlooked that question. >=20 > I am currently fairly indifferent about this, but since the library is kind= of small, it might be a better idea to have it as part of the core system. Shipping libsodium has been added to CU171 so then we leave things as=20 they currently are. Regards, Adolf. >=20 > -Michael >=20 >> On 27 Sep 2022, at 09:09, Adolf Belka wrote: >> >> Hi Michael, >> >> On 18/09/2022 12:44, Adolf Belka wrote: >>> Hi Michael, >>> >>> On 18/09/2022 11:08, Michael Tremer wrote: >>>> Why? >>> Because dnsdist has the default for the configure option of --with-libsod= ium set to auto so in the p[ast dnsdist was built without linking to libsodiu= m. With the introduction of libsodium into the build dnsdist automatically fo= und it and linked to it. >>> >>> So when libsodium was not shipped then dnsdist fails because it can't fin= d the linked libsodium.so.23 file. >>> >>> If you don't want to ship libsodium, then the other alternative is that I= can raise a patch to add --without-libsodium to the dnsdist configure. That = will make it build and run with libsodium being in the build but not in the s= hipped core packages. >>> >>> Which way should I do this? >>> >> Is there a decision made about which option to use? >> - Ship libsodium in core IPFire >> - Build dnsdist without libsodium >> >> Regards, >> Adolf >>> Regards, >>> >>> Adolf. >>>> >>>>> On 17 Sep 2022, at 23:09, Adolf Belka wrote: >>>>> >>>>> Reviewed-by: Adolf Belka >>>>> >>>>> On 17/09/2022 18:53, Peter M=C3=BCller wrote: >>>>>> Fixes: #12929 >>>>>> Signed-off-by: Peter M=C3=BCller >>>>>> --- >>>>>> config/rootfiles/core/171/filelists/libsodium | 1 + >>>>>> 1 file changed, 1 insertion(+) >>>>>> create mode 120000 config/rootfiles/core/171/filelists/libsodium >>>>>> >>>>>> diff --git a/config/rootfiles/core/171/filelists/libsodium b/config/ro= otfiles/core/171/filelists/libsodium >>>>>> new file mode 120000 >>>>>> index 000000000..ebd862fbc >>>>>> --- /dev/null >>>>>> +++ b/config/rootfiles/core/171/filelists/libsodium >>>>>> @@ -0,0 +1 @@ >>>>>> +../../../common/libsodium >>>>>> \ No newline at end of file >>>>> >>>>> --=20 >>>>> Sent from my laptop >>>> >> >> --=20 >> Sent from my laptop >=20 --=20 Sent from my laptop --===============3075069242319494565==--