From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter =?utf-8?q?M=C3=BCller?= To: development@lists.ipfire.org Subject: Re: Trying to update gd Date: Sat, 19 Jun 2021 08:09:50 +0200 Message-ID: In-Reply-To: <939f59ab-2116-7bf4-2c65-0fa73ba4a9d7@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3131112611702610952==" List-Id: --===============3131112611702610952== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Adolf, reading this thread, I just stumbled across the part below, so I thought I sl= ip into the conversation. :-) > With memory.cgi I get an Internal Server Error. The log gives the following= :- >=20 > Bareword "collectd" not allowed while "strict subs" in use at /srv/web/ipfi= re/cgi-bin/memory.cgi line 59. > Bareword "localhost" not allowed while "strict subs" in use at /srv/web/ipf= ire/cgi-bin/memory.cgi line 59. > Bareword "swap" not allowed while "strict subs" in use at /srv/web/ipfire/c= gi-bin/memory.cgi line 59. > Execution of /srv/web/ipfire/cgi-bin/memory.cgi aborted due to compilation = errors. >=20 > Looking at line 59 and checking in git this looks to be related to a change= done by Stefan Schantl 8 days ago > https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dcommitdiff;h=3D4353c579248b3= 016740252009b4ed15a4c6f8fe3 >=20 > I don't want to commit the patch for gd until I have memory.cgi confirmed w= orking and enough firewall data to confirm the pie charts are working but it = looks close to completion. This is because of bug #12616, which required massive changes to nearly all o= f the CGIs. Stefan and Michael worked on this one, and their changes was merged into the "next" branch a few= days ago. Therefore, copying CGIs from "next" onto an already installed IPFire running = Core Update 156 is not suitable for testing, as C156 lacks additional Perl methods introduced by Stefan. Unless your changes to a CGI hit a part of it that has been modified, you can= still generate a patch of your changes, and apply that on an existing IPFire installation. This would look l= ike: (on your workstation) > git diff memory.cgi > memory-cgi-fixes.patch > scp memory-cgi-fixes.patch [FQDN or IP address of your IPFire]:/tmp/. (on the IPFire machine) > cd /srv/web/ipfire/cgi-bin/ > patch < /tmp/memory-cgi-fixes.patch Good luck, and happy patching. :-) Thanks, and best regards, Peter M=C3=BCller --===============3131112611702610952==--