From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] ddns: Add upstream patch to fix a typo for FreeDNSAfraid.org provider
Date: Sat, 23 Oct 2021 21:37:26 +0200 [thread overview]
Message-ID: <f920740d-ad24-b22d-508b-5eef9fb56ef7@ipfire.org> (raw)
In-Reply-To: <20211023191625.3014-1-stefan.schantl@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 2200 bytes --]
Reported-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
Tested-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
Am 23.10.2021 um 21:16 schrieb Stefan Schantl:
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> lfs/ddns | 2 +-
> .../ddns-014-freednsafraid-fix-typo.patch | 21 +++++++++++++++++++
> 2 files changed, 22 insertions(+), 1 deletion(-)
> create mode 100644 src/patches/ddns-014-freednsafraid-fix-typo.patch
>
> diff --git a/lfs/ddns b/lfs/ddns
> index b1d0f2dbb..873f927af 100644
> --- a/lfs/ddns
> +++ b/lfs/ddns
> @@ -72,7 +72,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE)
>
> # Apply upstream patches.
> - # No upstream patches at the moment.
> + cd $(DIR_APP) && patch -Np1 -i $(DIR_SRC)/src/patches/ddns-014-freednsafraid-fix-typo.patch
>
> cd $(DIR_APP) && [ -x "configure" ] || sh ./autogen.sh
> cd $(DIR_APP) && ./configure \
> diff --git a/src/patches/ddns-014-freednsafraid-fix-typo.patch b/src/patches/ddns-014-freednsafraid-fix-typo.patch
> new file mode 100644
> index 000000000..4982d52f4
> --- /dev/null
> +++ b/src/patches/ddns-014-freednsafraid-fix-typo.patch
> @@ -0,0 +1,21 @@
> +commit 3a162595b9b44a4cbf08a3db14a4d2ebfeeb5583
> +Author: Stefan Schantl <stefan.schantl(a)ipfire.org>
> +Date: Sat Oct 23 21:11:27 2021 +0200
> +
> + FreeDNSAfraid.org: Fix typo in checking if the IP has been changed.
> +
> + Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> +
> +diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> +index 4f27af9..5b2a82d 100644
> +--- a/src/ddns/providers.py
> ++++ b/src/ddns/providers.py
> +@@ -1204,7 +1204,7 @@ class DDNSProviderFreeDNSAfraidOrg(DDNSProvider):
> + output = response.read().decode()
> +
> + # Handle success messages.
> +- if output.startswith("Updated") or output.startswith("No IP changed detected"):
> ++ if output.startswith("Updated") or output.startswith("No IP change detected"):
> + return
> +
> + # Handle error codes.
>
prev parent reply other threads:[~2021-10-23 19:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-23 19:16 Stefan Schantl
2021-10-23 19:37 ` Bernhard Bitsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f920740d-ad24-b22d-508b-5eef9fb56ef7@ipfire.org \
--to=bbitsch@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox