From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] ddns: Add upstream patch to fix a typo for
 FreeDNSAfraid.org provider
Date: Sat, 23 Oct 2021 21:37:26 +0200
Message-ID: <f920740d-ad24-b22d-508b-5eef9fb56ef7@ipfire.org>
In-Reply-To: <20211023191625.3014-1-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8228231307263512956=="
List-Id: <development.lists.ipfire.org>

--===============8228231307263512956==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reported-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
Tested-by: Bernhard Bitsch <bbitsch(a)ipfire.org>

Am 23.10.2021 um 21:16 schrieb Stefan Schantl:
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
>   lfs/ddns                                      |  2 +-
>   .../ddns-014-freednsafraid-fix-typo.patch     | 21 +++++++++++++++++++
>   2 files changed, 22 insertions(+), 1 deletion(-)
>   create mode 100644 src/patches/ddns-014-freednsafraid-fix-typo.patch
>=20
> diff --git a/lfs/ddns b/lfs/ddns
> index b1d0f2dbb..873f927af 100644
> --- a/lfs/ddns
> +++ b/lfs/ddns
> @@ -72,7 +72,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>   	@rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE)
>  =20
>   	# Apply upstream patches.
> -	# No upstream patches at the moment.
> +	cd $(DIR_APP) && patch -Np1 -i $(DIR_SRC)/src/patches/ddns-014-freednsafr=
aid-fix-typo.patch
>  =20
>   	cd $(DIR_APP) && [ -x "configure" ] || sh ./autogen.sh
>   	cd $(DIR_APP) && ./configure \
> diff --git a/src/patches/ddns-014-freednsafraid-fix-typo.patch b/src/patche=
s/ddns-014-freednsafraid-fix-typo.patch
> new file mode 100644
> index 000000000..4982d52f4
> --- /dev/null
> +++ b/src/patches/ddns-014-freednsafraid-fix-typo.patch
> @@ -0,0 +1,21 @@
> +commit 3a162595b9b44a4cbf08a3db14a4d2ebfeeb5583
> +Author: Stefan Schantl <stefan.schantl(a)ipfire.org>
> +Date:   Sat Oct 23 21:11:27 2021 +0200
> +
> +    FreeDNSAfraid.org: Fix typo in checking if the IP has been changed.
> +
> +    Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> +
> +diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> +index 4f27af9..5b2a82d 100644
> +--- a/src/ddns/providers.py
> ++++ b/src/ddns/providers.py
> +@@ -1204,7 +1204,7 @@ class DDNSProviderFreeDNSAfraidOrg(DDNSProvider):
> + 		output =3D response.read().decode()
> +
> + 		# Handle success messages.
> +-		if output.startswith("Updated") or output.startswith("No IP changed det=
ected"):
> ++		if output.startswith("Updated") or output.startswith("No IP change dete=
cted"):
> + 			return
> +
> + 		# Handle error codes.
>=20

--===============8228231307263512956==--