Re: services.cgi throws "XXXX is experimental"

[Adolf Belka <adolf.belka@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1817 bytes --]

Hi Jon,

I just tested it out on my system and it does work. Will you raise a patch for this?


Regards,

Adolf.


On 16/01/2023 12:55, Adolf Belka wrote:
> Hi Jon,
>
> On 15/01/2023 19:54, jon wrote:
>> Not sure if this was corrected or not…
>>
>> This can be added to the code.
>>
>>  1. nowarnings 'experimental';
>
> Has this been tested and confirmed to work or does this still need to be checked before submitting any patch?
>
> Regards,
> Adolf.
>>
>>
>>
>> Jon Murphy
>> murphy.jon(a)me.com <mailto:murphy.jon(a)me.com>
>>
>>> On Dec 30, 2022, at 6:06 AM, Adolf Belka <adolf.belka(a)ipfire.org <mailto:adolf.belka(a)ipfire.org>> wrote:
>>>
>>> Hi Matthias,
>>>
>>> On 30/12/2022 10:52, Matthias Fischer wrote:
>>>> Hi,
>>>>
>>>> updated to Core 172 - no problems, everything went fine.
>>>>
>>>> But...
>>>>
>>>> Each time I open 'servies.cgi', two lines are added to
>>>> '/var/log/httpd/error_log':
>>>>
>>>> ***SNIP***
>>>> ...
>>>> given is experimental at /srv/web/ipfire/cgi-bin/services.cgi line 145.
>>>> when is experimental at /srv/web/ipfire/cgi-bin/services.cgi line 146.
>>>> ...
>>>> ***SNAP***
>>>>
>>>> Besides this, the GUI looks good.
>>>>
>>>> Can anyone confirm?
>>>
>>> Yes, I see the same thing.
>>>
>>> Checking the cgi code, these messages are occurring because Robin used the switch feature and perl currently still considers this experimental. So the code is working, there are no errors, just these lines are warnings. Not sure if these warnings can be turned off.
>>>
>>> Robin, could you look at if the warnings could be turned off.
>>>
>>>
>>> Regards,
>>>
>>> Adolf.
>>>
>>>> Best,
>>>>
>>>> Matthias
>>
>>
>>
>>
>> Jon Murphy
>> jon.murphy(a)ipfire.org <mailto:jon.murphy(a)ipfire.org>
>>
>>
>>