Re: [PATCH 1/2] Drop unmaintained add-on lcd4linux

[Adolf Belka <adolf.belka@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 7347 bytes --]

Reviewed-by: Adolf Belka <adolf.belka(a)ipfire.org>

On 02/06/2021 20:36, Peter Müller wrote:
> This package has not received any updates or attention within the last
> three years. It's sole known upstream URL (https://ssl.bulix.org/projects/lcd4linux/)
> returns a HTTP error 404 nowadays, and the author was unable to locate
> any upstream source that appears to be still maintained today.
>
> Given the status quo, bugs in lcd4linux cannot be reported properly,
> security issues won't be addressed (by anybody else then ourselves), and
> technical questions cannot be clarified aside a reverse engineering
> approach.
>
> We should not allow such an add-on to be installed on a firewall system.
>
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
>   config/backup/includes/lcd4linux    |  1 -
>   config/rootfiles/packages/lcd4linux |  3 -
>   lfs/lcd4linux                       | 92 -----------------------------
>   make.sh                             |  1 -
>   src/initscripts/packages/lcd4linux  | 46 ---------------
>   5 files changed, 143 deletions(-)
>   delete mode 100644 config/backup/includes/lcd4linux
>   delete mode 100644 config/rootfiles/packages/lcd4linux
>   delete mode 100644 lfs/lcd4linux
>   delete mode 100644 src/initscripts/packages/lcd4linux
>
> diff --git a/config/backup/includes/lcd4linux b/config/backup/includes/lcd4linux
> deleted file mode 100644
> index 40fa69c51..000000000
> --- a/config/backup/includes/lcd4linux
> +++ /dev/null
> @@ -1 +0,0 @@
> -/etc/lcd4linux.conf
> diff --git a/config/rootfiles/packages/lcd4linux b/config/rootfiles/packages/lcd4linux
> deleted file mode 100644
> index 226daf418..000000000
> --- a/config/rootfiles/packages/lcd4linux
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -usr/bin/lcd4linux
> -var/ipfire/backup/addons/includes/lcd4linux
> -etc/rc.d/init.d/lcd4linux
> diff --git a/lfs/lcd4linux b/lfs/lcd4linux
> deleted file mode 100644
> index 9121e6fa0..000000000
> --- a/lfs/lcd4linux
> +++ /dev/null
> @@ -1,92 +0,0 @@
> -###############################################################################
> -#                                                                             #
> -# IPFire.org - A linux based firewall                                         #
> -# Copyright (C) 2007-2018  IPFire Team  <info(a)ipfire.org>                     #
> -#                                                                             #
> -# This program is free software: you can redistribute it and/or modify        #
> -# it under the terms of the GNU General Public License as published by        #
> -# the Free Software Foundation, either version 3 of the License, or           #
> -# (at your option) any later version.                                         #
> -#                                                                             #
> -# This program is distributed in the hope that it will be useful,             #
> -# but WITHOUT ANY WARRANTY; without even the implied warranty of              #
> -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the               #
> -# GNU General Public License for more details.                                #
> -#                                                                             #
> -# You should have received a copy of the GNU General Public License           #
> -# along with this program.  If not, see <http://www.gnu.org/licenses/>.       #
> -#                                                                             #
> -###############################################################################
> -
> -###############################################################################
> -# Definitions
> -###############################################################################
> -
> -include Config
> -
> -VER        = 0.11.0-svn1200-dpf
> -
> -THISAPP    = lcd4linux-$(VER)
> -DL_FILE    = $(THISAPP).tar.gz
> -DL_FROM    = $(URL_IPFIRE)
> -DIR_APP    = $(DIR_SRC)/lcd4linux
> -TARGET     = $(DIR_INFO)/$(THISAPP)
> -PROG       = lcd4linux
> -PAK_VER    = 7
> -
> -DEPS       = dpfhack libmpdclient
> -
> -###############################################################################
> -# Top-level Rules
> -###############################################################################
> -
> -objects = $(DL_FILE)
> -
> -$(DL_FILE) = $(DL_FROM)/$(DL_FILE)
> -
> -$(DL_FILE)_MD5 = 5b76a26879849dbd52a5bcfda4107ea4
> -
> -install : $(TARGET)
> -
> -check : $(patsubst %,$(DIR_CHK)/%,$(objects))
> -
> -download :$(patsubst %,$(DIR_DL)/%,$(objects))
> -
> -md5 : $(subst %,%_MD5,$(objects))
> -
> -dist:
> -	$(PAK)
> -
> -###############################################################################
> -# Downloading, checking, md5sum
> -###############################################################################
> -
> -$(patsubst %,$(DIR_CHK)/%,$(objects)) :
> -	@$(CHECK)
> -
> -$(patsubst %,$(DIR_DL)/%,$(objects)) :
> -	@$(LOAD)
> -
> -$(subst %,%_MD5,$(objects)) :
> -	@$(MD5)
> -
> -###############################################################################
> -# Installation Details
> -###############################################################################
> -
> -$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> -	@$(PREBUILD)
> -	@rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE)
> -	$(UPDATE_AUTOMAKE)
> -	cd $(DIR_APP) && autoreconf -v -i
> -	cd $(DIR_APP) && autoupdate -v configure.in
> -	cd $(DIR_APP) && ./configure  --with-plugins=all,!qnaplog,!dbus --prefix=/usr
> -	cd $(DIR_APP) && make $(MAKETUNING)
> -	cd $(DIR_APP) && make install
> -
> -	#install initscripts
> -	$(call INSTALL_INITSCRIPT,lcd4linux)
> -
> -	install -v -m 644 $(DIR_SRC)/config/backup/includes/lcd4linux /var/ipfire/backup/addons/includes/lcd4linux
> -	@rm -rf $(DIR_APP)
> -	@$(POSTBUILD)
> diff --git a/make.sh b/make.sh
> index b5dbfae5d..9f9fd7b0e 100755
> --- a/make.sh
> +++ b/make.sh
> @@ -1547,7 +1547,6 @@ buildipfire() {
>     lfsmake2 aws-cli
>     lfsmake2 transmission
>     lfsmake2 dpfhack
> -  lfsmake2 lcd4linux
>     lfsmake2 mtr
>     lfsmake2 minidlna
>     lfsmake2 acpid
> diff --git a/src/initscripts/packages/lcd4linux b/src/initscripts/packages/lcd4linux
> deleted file mode 100644
> index 34f8c8b46..000000000
> --- a/src/initscripts/packages/lcd4linux
> +++ /dev/null
> @@ -1,46 +0,0 @@
> -#!/bin/sh
> -# Begin $rc_base/init.d/lcd4linux
> -
> -
> -. /etc/sysconfig/rc
> -. $rc_functions
> -
> -case "$1" in
> -	start)
> -		boot_mesg "Starting lcd4linux..."
> -		if [ ! -f /etc/lcd4linux.conf ]; then
> -			boot_mesg "No configuration file found, not starting."
> -			exit 1
> -		fi
> -
> -		loadproc /usr/bin/lcd4linux
> -		;;
> -
> -	stop)
> -		boot_mesg "Stopping lcd4linux..."
> -		killproc /usr/bin/lcd4linux
> -		;;
> -
> -	reload)
> -		boot_mesg "Reloading lcd4linux..."
> -		reloadproc /usr/bin/lcd4linux
> -		;;
> -
> -	restart)
> -		$0 stop
> -		sleep 3
> -		$0 start
> -		;;
> -
> -	status)
> -		statusproc /usr/bin/lcd4linux
> -		;;
> -
> -	*)
> -		echo "Usage: $0 {start|stop|reload|restart|status}"
> -		exit 1
> -		;;
> -esac
> -
> -
> -# End $rc_base/init.d/lcd4linux