public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] updatexlrator.cgi: Fix max disk usage input size
Date: Thu, 12 Aug 2021 21:01:48 +0200	[thread overview]
Message-ID: <fc8ad37a-c025-27ab-baba-fc9386741db8@ipfire.org> (raw)
In-Reply-To: <20210812095148.855-1-hofmann@leo-andres.de>

[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]

Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>

Am 12.08.2021 um 11:51 schrieb Leo-Andres Hofmann:
> Increase to 3 digits to fit a percentage number.
> 
> Fixes: #12675
> 
> Reported-by: Adolf Belka <adolf.belka(a)ipfire.org>
> Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
> ---
>   html/cgi-bin/updatexlrator.cgi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/html/cgi-bin/updatexlrator.cgi b/html/cgi-bin/updatexlrator.cgi
> index 9cfe08f4e..4d5cc1370 100644
> --- a/html/cgi-bin/updatexlrator.cgi
> +++ b/html/cgi-bin/updatexlrator.cgi
> @@ -398,7 +398,7 @@ print <<END
>   	<td class='base'>$Lang::tr{'updxlrtr passive mode'}:</td>
>   	<td class='base'><input type='checkbox' name='PASSIVE_MODE' $checked{'PASSIVE_MODE'}{'on'} /></td>
>   	<td class='base'>$Lang::tr{'updxlrtr max disk usage'}:&nbsp;<img src='/blob.gif' alt='*' /></td>
> -	<td class='base'><input type='text' name='MAX_DISK_USAGE' value='$xlratorsettings{'MAX_DISK_USAGE'}' size='1' /> %</td>
> +	<td class='base'><input type='text' name='MAX_DISK_USAGE' value='$xlratorsettings{'MAX_DISK_USAGE'}' size='3' /> %</td>
>   </tr>
>   </table>
>   <hr size='1'>
> 

      parent reply	other threads:[~2021-08-12 19:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12  9:51 Leo-Andres Hofmann
2021-08-12 10:31 ` Michael Tremer
2021-08-12 19:01 ` Bernhard Bitsch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc8ad37a-c025-27ab-baba-fc9386741db8@ipfire.org \
    --to=bbitsch@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox