From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <development+bounces-1094-archive=lists.ipfire.org@lists.ipfire.org>
Received: from mail02.haj.ipfire.org (localhost [IPv6:::1])
	by mail02.haj.ipfire.org (Postfix) with ESMTP id 4cXZqq5vHXz2yqQ
	for <archive@lists.ipfire.org>; Thu, 25 Sep 2025 13:51:03 +0000 (UTC)
Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384
	 client-signature RSA-PSS (4096 bits) client-digest SHA256)
	(Client CN "mail01.haj.ipfire.org", Issuer "R13" (verified OK))
	by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4cXZqm2szBz2xM3
	for <development@lists.ipfire.org>; Thu, 25 Sep 2025 13:51:00 +0000 (UTC)
Received: from [127.0.0.1] (localhost [127.0.0.1])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by mail01.ipfire.org (Postfix) with ESMTPSA id 4cXZql5YWbz2Jy
	for <development@lists.ipfire.org>; Thu, 25 Sep 2025 13:50:59 +0000 (UTC)
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org;
	s=202003ed25519; t=1758808259;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=tyXSTvxoWlUgUHUes59NJDjz1dJLX+ca8NJ3cPtjYLo=;
	b=0EmNt8Oq9NogoSEAh+nNWwzZkM7tYVr0dF/A2eShM4zthqWCSE7CuYiov8OrAzdtfvm5oX
	WJBzIzJuzrDcUyCw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa;
	t=1758808259;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=tyXSTvxoWlUgUHUes59NJDjz1dJLX+ca8NJ3cPtjYLo=;
	b=PMIm0IoOLyDI1dscOCy/5Ee9f563IeuW7XpoeEV8Q+lJvDIKLZw9wcvG4FfBsOSK5PrZWW
	yU5knGuwJsAxe5YYtxPq3PUd+RWLNagA9dRzwm+w2BJ9Tltbj8vFkPNv4Z9bRaLiR2VxzH
	Y52HIdStYIXjtol+3iK79NvEJZRf972DZVQ4TVHloJvjJ8GNgwY1pbVDJXEDc4wkDDanjv
	djZmYVdb50q3EUJR8gveU5DI1T8eP5turvZZBXw42CJKAabcsmA+oe9jME/jGQri9goP9Y
	0L2keAGZV3Zo/HuIsd5gNcM7dAIgZHNV0VbHcC8Qup0/DUVLHRjkYEAdkO0bAQ==
Message-ID: <fe120557-484d-45cc-96cb-c7273ea8d8d7@ipfire.org>
Date: Thu, 25 Sep 2025 15:50:58 +0200
Precedence: list
List-Id: <development.lists.ipfire.org>
List-Subscribe: <https://lists.ipfire.org/>,
 <mailto:development+subscribe@lists.ipfire.org?subject=subscribe>
List-Unsubscribe: <https://lists.ipfire.org/>,
 <mailto:development+unsubscribe@lists.ipfire.org?subject=unsubscribe>
List-Post: <mailto:development@lists.ipfire.org>
List-Help: <mailto:development+help@lists.ipfire.org?subject=help>
Sender: <development@lists.ipfire.org>
Mail-Followup-To: <development@lists.ipfire.org>
MIME-Version: 1.0
Subject: Re: [PATCH 08/16] ddns.cgi: Fixes bug 13884
To: development@lists.ipfire.org
References: <20250925111252.11893-1-adolf.belka@ipfire.org>
 <20250925111252.11893-8-adolf.belka@ipfire.org>
Content-Language: en-GB
From: Bernhard Bitsch <bbitsch@ipfire.org>
In-Reply-To: <20250925111252.11893-8-adolf.belka@ipfire.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org>

Am 25.09.2025 um 13:12 schrieb Adolf Belka:
> Fixes: bug 13884 - ddns.cgi LOGIN PASSWORD SERVICE Stored Cross-Site Scripting
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
>   html/cgi-bin/ddns.cgi | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/html/cgi-bin/ddns.cgi b/html/cgi-bin/ddns.cgi
> index 34475b75c..60565da3f 100644
> --- a/html/cgi-bin/ddns.cgi
> +++ b/html/cgi-bin/ddns.cgi
> @@ -2,7 +2,7 @@
>   ###############################################################################
>   #                                                                             #
>   # IPFire.org - A linux based firewall                                         #
> -# Copyright (C) 2007-2014  IPFire Team  <info@ipfire.org>                     #
> +# Copyright (C) 2007-2025  IPFire Team  <info@ipfire.org>                     #
>   #                                                                             #
>   # This program is free software: you can redistribute it and/or modify        #
>   # it under the terms of the GNU General Public License as published by        #
> @@ -226,6 +226,9 @@ if (($settings{'ACTION'} eq $Lang::tr{'add'}) || ($settings{'ACTION'} eq $Lang::
>   			flock FILE, 2;
>   
>   			# Add account data to the file.
> +			$settings{'SERVICE'} = &Header::escape(($settings{'SERVICE'});
> +			$settings{'LOGIN'} = &Header::escape(($settings{'LOGIN'});
> +			$settings{'PASSWORD'} = &Header::escape(($settings{'PASSWORD'});
>   			print FILE "$settings{'SERVICE'},$hostname,$domain,$settings{'PROXY'},$settings{'WILDCARDS'},$settings{'LOGIN'},$settings{'PASSWORD'},$settings{'ENABLED'}\n";
>   
>   			# Close file after writing.