From mboxrd@z Thu Jan  1 00:00:00 1970
From: ummeegge <ummeegge@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] OpenVPN: Fix max-clients option
Date: Mon, 04 Nov 2019 17:46:46 +0100
Message-ID: <ff5d3b8c49745bda22e7ac8594cd8edfa762ebd3.camel@ipfire.org>
In-Reply-To: <CF7EF2BF-4594-4673-9F3D-EECDA9BA714B@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8298924404866249113=="
List-Id: <development.lists.ipfire.org>

--===============8298924404866249113==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

On Mo, 2019-11-04 at 16:32 +0000, Michael Tremer wrote:
> Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
> 
> Interesting is how long this has been in here unnoticed.
A long time...

> 
> > On 4 Nov 2019, at 14:52, Erik Kapfer <ummeegge(a)ipfire.org> wrote:
> > 
> > Fix: Triggered by 
> > https://forum.ipfire.org/viewtopic.php?f=16&t=23551
> > 
> > Since the 'DHCP_WINS' cgiparam has been set for the max-client
> > directive, changes in the WUI has not been adapted to server.conf.
> > 
> > Signed-off-by: Erik Kapfer <ummeegge(a)ipfire.org>
> > ---
> > html/cgi-bin/ovpnmain.cgi | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
> > index 970444a55..09f0dc42f 100644
> > --- a/html/cgi-bin/ovpnmain.cgi
> > +++ b/html/cgi-bin/ovpnmain.cgi
> > @@ -355,10 +355,10 @@ sub writeserverconf {
> >         print CONF "push \"dhcp-option WINS
> > $sovpnsettings{DHCP_WINS}\"\n";
> >     }
> > 
> > -    if ($sovpnsettings{DHCP_WINS} eq '') {
> > +    if ($sovpnsettings{MAX_CLIENTS} eq '') {
> > 	print CONF "max-clients 100\n";
> >     }
> > -    if ($sovpnsettings{DHCP_WINS} ne '') {
> > +    if ($sovpnsettings{MAX_CLIENTS} ne '') {
> > 	print CONF "max-clients $sovpnsettings{MAX_CLIENTS}\n";
> >     }	
> >     print CONF "tls-verify /usr/lib/openvpn/verify\n";
> > -- 
> > 2.12.2
> > 
> 
> 


--===============8298924404866249113==--