public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: reversion of access.log commenting out in rootfile
Date: Fri, 09 Aug 2024 17:25:21 +0200	[thread overview]
Message-ID: <ffbb9e49-2e49-489b-aa4c-1abee0652ee0@ipfire.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

Hi Arne,

I saw that my patch for commenting out the access.log in the rootfile had been reverted.

https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=97067db7862450bb40d4e9188627d6b5585bf931

I don't understand the meaning of

"the file was created to be shipped with permissions
so it is needed in the rootfile."

If it has to stay how do we ensure that users don't lose maybe up to a weeks worth of the access.log file if an update is done on the day before access.log would be rotated to access.log.1 .gz

Although this has always been the case, it doesn't seem right to overwrite the existing access.log file if squid is updated or have I misunderstood something?

Regards,

Adolf.


             reply	other threads:[~2024-08-09 15:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-09 15:25 Adolf Belka [this message]
2024-08-13  9:57 ` Michael Tremer
2024-08-13 11:04   ` Adolf Belka
2024-08-21 10:04     ` Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ffbb9e49-2e49-489b-aa4c-1abee0652ee0@ipfire.org \
    --to=adolf.belka@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox