public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Question regarding commit 5b4fc4c8493747af7a6772e1085ef0d45c9ab6af
Date: Sat, 11 Sep 2021 11:45:32 +0200	[thread overview]
Message-ID: <ffd5e641-717b-56d1-a7f2-24596482184f@ipfire.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 701 bytes --]

Hello Arne,

by accident, I just came across commit 5b4fc4c8493747af7a6772e1085ef0d45c9ab6af and this
"diff" output: https://git.ipfire.org/?p=ipfire-2.x.git;a=blobdiff;f=config/rootfiles/oldcore/151/update.sh;h=cec3066c1df423debebecab716f11305e534bdeb;hp=5fb05488b589f0594c96c2ad6e5c67a1ac6d90a9;hb=5b4fc4c8493747af7a6772e1085ef0d45c9ab6af;hpb=c1418e6fc8adc765de60a0c15a977e445c260c72

Frankly, I did not understand why you changed "/etc/init.d/ipsec stop" to "/etc/init.d/ipsec start":
IPsec is started later in this script, if it is enabled, and the comment above reads "stop services".

No offense intended, but is this change intentional? :-)

Thanks, and best regards,
Peter Müller

             reply	other threads:[~2021-09-11  9:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-11  9:45 Peter Müller [this message]
2021-09-21 10:11 ` Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ffd5e641-717b-56d1-a7f2-24596482184f@ipfire.org \
    --to=peter.mueller@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox