Re: Bug #10918 was: [ANNOUNCE] Good First Bugs

Re: Bug #10918 was: [ANNOUNCE] Good First Bugs

[Larsen]

[-- Attachment #1: Type: text/plain, Size: 975 bytes --]

On Mon, 19 Oct 2015 12:24:36 +0200, Blago Culjak  
<blago.culjak(a)hotmail.com> wrote:

> It seems hard for me to get it in format that you guys use and if some  
> one has some template of e-mail i should use or commands you use to get  
> that diff output, I would be grateful.

Are you on Windows or Linux?
I could send you the notes I use for Windows with Tortoisegit this evening  
(newbie myself).


> [PATCH] package: Typo in Traffic Meter
>
> This solves bug 10918
>     Signed-off-by: Blago Culjak <blago.culjak(a)hotmail.com>
>

I suppose the first line would be your subject of the mail.

Then you are missing an explanatory line what this patch does and why this  
is necessary.
More detail can optionally be specified after a blank line (this also  
includes "This solves...")
"Signed-off-by" should be separated by another blank line.

Make sure to use text-format instead of HTML for your mail.
Don't use line-wrapping
--> What mail program do you use?


Lars

Re: Bug #10918 was: [ANNOUNCE] Good First Bugs

[Larsen]

[-- Attachment #1: Type: text/plain, Size: 820 bytes --]

> Thanks again for guidelines,just one question more, what command/GUI  
> output you use to make correct patch diff output on Windows?

== Create a patch ==
* Activate your local feature branch
* Rebase, when the remote branch has been updated inbetween:
     * Right-click on the folder where the IPFire-code is located
     * TortoiseGit > Rebase...
     * Branch: Your local feature branch
     * Upstream: next
     * Select the newest ID and start the rebase
* Right-click on the folder where the IPFire-code is located
* TortoiseGit > Revision graph
* Select the block "next - origin/next"
* While holding the ctrl-key select your local feature branch
* Right-click > Unified diff
* Ctrl+Shift+S to save the patch to a file

Not 100% sure about the rebase procedure, but has been working till then =)


hth,
Lars

Re: Bug #10918 was: [ANNOUNCE] Good First Bugs

[Larsen]

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

On Mon, 19 Oct 2015 13:05:36 +0200, Blago Culjak  
<blago.culjak(a)hotmail.com> wrote:

>> Make sure to use text-format instead of HTML for your mail.
>> Don't use line-wrapping
>> --> What mail program do you use?
> I use web based live.com, but it can use text-format, don't worry.

Are you sure that this also implies that line-wrapping is disabled?


> If you could send me those notes, or even update it on wiki, it would be  
> great benefit.

Yes sure, will send you some text this evening (CEST).
afaik, everything is already in the wiki. it's just some kind of  
cheat-sheet.


Lars

Re: Bug #10918 was: [ANNOUNCE] Good First Bugs

[Larsen]

[-- Attachment #1: Type: text/plain, Size: 895 bytes --]

> If you could send me those notes, or even update it on wiki, it would be  
> great benefit.

Here you go:


== Send in a patch ==
* Thunderbird > Compose new mail
* Options > Enable Word Wrap: disable
* Recipient: development(a)lists.ipfire.org <development(a)lists.ipfire.org>
* Subject: [PATCH] <text>
* Body:
First line contains a short description of the patch.

After a blank line, a more precise description follows (if needed; you can  
leave that out for smaller patches). Optionally together with a "Fixes bug  
<number>" in case the patch fixes a bug

Signed-off-by: Your Name <your(a)email.adress>
---

* After the "---" and blank line you put the patch as plain text
* Having sent the mail to the list, you can check  
http://patchwork.ipfire.org/project/ipfire/list
* In case there is a corresponding bug in the bugtracker, you should add a  
note there with the URL to the patch

Bug #10918 was: [ANNOUNCE] Good First Bugs

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 2155 bytes --]

Hello,

thanks for taking this opportunity this quickly.

On Sat, 2015-10-17 at 08:44 +0200, Blago Culjak wrote:
> Hello, Michael, I have taken-over bug, 
> https://bugzilla.ipfire.org/show_bug.cgi?id=10918, made changed, now
> bug is gone on my test system.
> 
> How should I send it to you guys for merge?

Please follow this guide: http://wiki.ipfire.org/devel/submit-patches

Feel free to ask questions if anything is not clear.

> I have changed 54 line of
> /srv/web/ipfire/html/themes/ipfire/include/js/refreshInetInfo.js and
> it works fine, in kbits/mbits...

There are also other themes, did you check these as well? There is also
a short moment after a page is loaded when the JS is not executed, yet.
I am just wondering if it says "kBit" there as well.

> 
> Thank you for helping out a new guy.

-Michael

P.S. Please make sure to reply to the list as well.

> 
> 
> > Subject: [ANNOUNCE] Good First Bugs
> > From: michael.tremer(a)ipfire.org
> > To: development(a)lists.ipfire.org
> > Date: Fri, 16 Oct 2015 22:08:21 +0100
> > 
> > Hello,
> > 
> > as discussed at the IPFire Developer Summit 2015, we are now
> > introducing "Good First Bugs". These are bugs tagged with the
> keyword
> > "GoodFirstBug" and recommended for beginners to solve.
> > 
> > They should help us to encourage more people to start development
> with
> > IPFire and are tasks that should be resolvable in a reasonable
> amount
> > of time. They usually should not require knowledge in any advanced
> > programming languages.
> > 
> > http://wiki.ipfire.org/devel/bugzilla/good-first-bug
> > 
> > These bugs can be found by searching for the keyword on Bugzilla:
> > 
> > https://bugzilla.ipfire.org/buglist.cgi?keywords=GoodFirstBug
> > 
> > This message is to all the developers who should tag appropriate
> bugs
> > as such, encourage people to take on a bug and mentor them if any
> help
> > is needed.
> > 
> > There will also be a post on the IPFire planet release some time
> next
> > week to announce this to the people who are following our blog and
> > other social media.
> > 
> > http://planet.ipfire.org/post/good-first-bugs
> > 
> > Best,
> > -Michael

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]