public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Larsen <larsen007@web.de>
To: development@lists.ipfire.org
Subject: Re: Aw: Re:  [PATCH] Fix hardcoded strings in pppsetup.cgi
Date: Tue, 02 Jun 2015 21:49:24 +0200	[thread overview]
Message-ID: <op.xzmb0movcahio0@honk.fritz.box> (raw)
In-Reply-To: <op.xzlkw2ewcahio0@atl-uetersen.atlantisgmbh.local>

[-- Attachment #1: Type: text/plain, Size: 2505 bytes --]

Some strings for PPTP were hardcoded instead of using i18n features.

Signed-off-by: Lars Schuhmacher <larsen007(a)web.de>
---
  html/cgi-bin/pppsetup.cgi | 6 +++---
  langs/de/cgi-bin/de.pl    | 3 +++
  langs/en/cgi-bin/en.pl    | 3 +++
  3 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/html/cgi-bin/pppsetup.cgi b/html/cgi-bin/pppsetup.cgi
index 33f521e..59677a4 100644
--- a/html/cgi-bin/pppsetup.cgi
+++ b/html/cgi-bin/pppsetup.cgi
@@ -793,15 +793,15 @@ print <<END
          <td colspan='4' width='100%' bgcolor='$color{'color20'}'><b>$Lang::tr{'pptp settings'}</b></td>
  </tr>
  <tr>
-        <td width='25%'>Peer</td>
+        <td width='25%'>$Lang::tr{'pptp peer'}:</td>
          <td colspan='3'><input size=50 type='text' name='PPTP_PEER' value='$pppsettings{'PPTP_PEER'}' /></td>
  </tr>
  <tr>
-        <td width='25%'>My Netconfig</td>
+        <td width='25%'>$Lang::tr{'pptp netconfig'}:</td>
          <td colspan='3'><input size=50 type='text' name='PPTP_NICCFG' value='$pppsettings{'PPTP_NICCFG'}' /></td>
  </tr>
  <tr>
-        <td width='25%'>PPTP Route&nbsp;<img src='/blob.gif' alt='*' /></td>
+        <td width='25%'>$Lang::tr{'pptp route'}:&nbsp;<img src='/blob.gif' alt='*' /></td>
          <td colspan='3'><input size=50 type='text' name='PPTP_ROUTE' value='$pppsettings{'PPTP_ROUTE'}' /></td>
  </tr>

diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl
index 8adefdf..65277a9 100644
--- a/langs/de/cgi-bin/de.pl
+++ b/langs/de/cgi-bin/de.pl
@@ -1822,6 +1822,9 @@
  'ppp setup' => 'PPP-Einstellungen',
  'pppoe' => 'PPPoE',
  'pppoe settings' => 'Zusätzliche PPPoE-Einstellungen:',
+'pptp netconfig' => 'Eigene Netzkonfiguration',
+'pptp peer' => 'Gegenstelle',
+'pptp route' => 'PPTP Route',
  'pptp settings' => 'Zusätzliche PPTP-Einstellungen:',
  'pre-shared key is too short' => 'Pre-shared Schlüsel ist zu kurz',
  'prefered master' => 'Prefered Master',
diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl
index 43601c8..3e60b00 100644
--- a/langs/en/cgi-bin/en.pl
+++ b/langs/en/cgi-bin/en.pl
@@ -1852,6 +1852,9 @@
  'ppp setup' => 'PPP setup',
  'pppoe' => 'PPPoE',
  'pppoe settings' => 'Additional PPPoE settings:',
+'pptp netconfig' => 'My Netconfig',
+'pptp peer' => 'Peer',
+'pptp route' => 'PPTP Route',
  'pptp settings' => 'Additional PPTP settings:',
  'pre-shared key is too short' => 'Pre-shared key is too short.',
  'prefered master' => 'Prefered Master',

  reply	other threads:[~2015-06-02 19:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1433079323.3370.92.camel@ipfire.org>
2015-06-01 20:59 ` Larsen
2015-06-01 21:57   ` Aw: " Bernhard Bitsch
2015-06-02  6:58     ` Larsen
2015-06-02  8:51       ` Aw: " Bernhard Bitsch
2015-06-02 10:04         ` Larsen
2015-06-02 19:49           ` Larsen [this message]
2015-06-02 20:01             ` Michael Tremer
2015-06-02 21:05               ` Larsen
2015-06-02 21:07                 ` Larsen
2015-06-04 16:23                   ` Michael Tremer
2015-06-04 20:52                     ` Problem with whitespace in patches Larsen
2015-06-05 13:25                       ` Michael Tremer
2015-06-05 13:29                         ` Larsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.xzmb0movcahio0@honk.fritz.box \
    --to=larsen007@web.de \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox