Re: [PATCH] Mark required input fields with a star

[Larsen <larsen007@web.de>]

[-- Attachment #1: Type: text/plain, Size: 1405 bytes --]

On Fri, 05 Jun 2015 16:43:51 +0200, Michael Tremer  
<michael.tremer(a)ipfire.org> wrote:

>> +    <td class='base'>next-server:</td>
>>      <td><input type='text' name='NEXT_${itf}'  
>> value='$dhcpsettings{"NEXT_${itf}"}' /></td>
>> -    <td class='base'>filename:&nbsp;<img src='/blob.gif' alt='*'  
>> /></td>
>> +    <td class='base'>filename:</td>
>>      <td><input type='text' name='FILE_${itf}'  
>> value='$dhcpsettings{"FILE_${itf}"}' /></td>
>>  </tr>
>>  </table>
>
> There are some hard-coded strings here. These are not newly introduced
> but still we should fix them in an other patch later. I am sure you have
> come across a couple of them.

Didn´t notice before, but made a note on my todo-list for later.



On Fri, 05 Jun 2015 16:45:05 +0200, Michael Tremer  
<michael.tremer(a)ipfire.org> wrote:

> On Thu, 2015-06-04 at 23:46 +0200, Larsen wrote:
>> PS: Need help with the TODOs in that patch as I am now web developer
>> and where I don´t know how to use an if-clause.
>
> As these are in the ovpnmain.cgi (as far as I have seen) you should get
> in touch with Alex when he is back from holiday. That will be towards
> the end of next week.

Should not be related to ovpnmain.cgi. I just don´t have the experience  
how to combine html-code and if-clauses here. Any dev might be able to  
give a hint here.

btw: Will be on vacation myself from june 14th to june 22nd.


Lars