Re: IPCop Banish Addon for IPFire

[Bob Brewer <ipfire-devel@grantura.co.uk>]

[-- Attachment #1: Type: text/plain, Size: 1299 bytes --]

Matthias Fischer wrote:

> Being curious - as always - I tried to install Banish on my testmachine.
> 
> But the install script has a problem:
> 
> ***SNIP***
> [root(a)ipfiretest Banish-IPFire]# ./install_Banish.sh
> Starting Banish-IPFire 1.0.1 installation
> 
> Checking if files extracted to /tmp....OK!
> Checking files.........................OK!
> ...OK!
> Backing up files.....................Done!
> Extracting files.....................Done!
> Installing system files..............Done!
> Appending to files...................Done!
> Starting Banish......................./install_Banish.sh: line 258:
> /etc/rc.d/init.d/banish: No such file or directory
> Done!
> Cleaning up..........................Done!
> ***SNAP***
> 
> It seems that line 170 uses the wrong destination:
> 
> ...
> /bin/cp -p Banish/etc/rc.d/init.d/rc.banish /etc/rc.d/init.d/
> ...
> 
> This should have been '/etc/rc.d/init.d/banish'!?
> 
> The symlinks in line 173-175 are therefore affected, too. Banish won't
> start.
> 
> I corrected this manually, seems to work.
> 
> Testing...
> 

Ahhh... I made a late change to the init system and thought I had tested it 
out ok on my test system here before I uploaded it. 

Thank you for the feedback, I'll create a corrected 0.2 version and upload 
it to github.

Rob