From: Bob Brewer <ipfire-devel@grantura.co.uk>
To: development@lists.ipfire.org
Subject: Re: IPCop Banish Addon for IPFire
Date: Mon, 07 Jan 2019 12:38:54 +0000 [thread overview]
Message-ID: <q0vh8u$hiq$1@tuscan3.grantura.co.uk> (raw)
In-Reply-To: <q0vghv$gs1$1@tuscan3.grantura.co.uk>
[-- Attachment #1: Type: text/plain, Size: 1518 bytes --]
Bob Brewer wrote:
> Matthias Fischer wrote:
>
>> Being curious - as always - I tried to install Banish on my testmachine.
>>
>> But the install script has a problem:
>>
>> ***SNIP***
>> [root(a)ipfiretest Banish-IPFire]# ./install_Banish.sh
>> Starting Banish-IPFire 1.0.1 installation
>>
>> Checking if files extracted to /tmp....OK!
>> Checking files.........................OK!
>> ...OK!
>> Backing up files.....................Done!
>> Extracting files.....................Done!
>> Installing system files..............Done!
>> Appending to files...................Done!
>> Starting Banish......................./install_Banish.sh: line 258:
>> /etc/rc.d/init.d/banish: No such file or directory
>> Done!
>> Cleaning up..........................Done!
>> ***SNAP***
>>
>> It seems that line 170 uses the wrong destination:
>>
>> ...
>> /bin/cp -p Banish/etc/rc.d/init.d/rc.banish /etc/rc.d/init.d/
>> ...
>>
>> This should have been '/etc/rc.d/init.d/banish'!?
>>
>> The symlinks in line 173-175 are therefore affected, too. Banish won't
>> start.
>>
>> I corrected this manually, seems to work.
>>
>> Testing...
>>
>
> Ahhh... I made a late change to the init system and thought I had tested
> it out ok on my test system here before I uploaded it.
>
> Thank you for the feedback, I'll create a corrected 0.2 version and upload
> it to github.
>
Looking closer line 170 should have been:
/bin/cp -p Banish/etc/rc.d/init.d/rc.banish /etc/rc.d/init.d/rc.banish
then the symlinks would be OK
Rob
next prev parent reply other threads:[~2019-01-07 12:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-06 18:12 Bob Brewer
2019-01-07 7:39 ` Daniel Weismüller
2019-01-07 10:07 ` Bob Brewer
2019-01-07 12:17 ` Daniel Weismüller
2019-01-07 14:36 ` Bob Brewer
2019-01-07 12:13 ` Matthias Fischer
2019-01-07 12:26 ` Bob Brewer
2019-01-07 12:38 ` Bob Brewer [this message]
2019-01-07 14:48 ` Matthias Fischer
2019-01-07 19:28 ` Bob Brewer
2019-01-07 21:13 ` Matthias Fischer
2019-01-08 16:42 ` Bob Brewer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='q0vh8u$hiq$1@tuscan3.grantura.co.uk' \
--to=ipfire-devel@grantura.co.uk \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox